From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paolo Bonzini Subject: Re: [PATCH 19/19] migration: add a parser to accept FT migration incoming mode. Date: Fri, 28 Jan 2011 13:58:37 +0100 Message-ID: <4D42BD7D.8020004@redhat.com> References: <1296199312-26334-1-git-send-email-tamura.yoshiaki@lab.ntt.co.jp> <1296199312-26334-20-git-send-email-tamura.yoshiaki@lab.ntt.co.jp> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org, qemu-devel@nongnu.org, avi@redhat.com, anthony@codemonkey.ws, aliguori@us.ibm.com, mtosatti@redhat.com, dlaor@redhat.com, mst@redhat.com, kwolf@redhat.com, ananth@in.ibm.com, psuriset@linux.vnet.ibm.com, vatsa@linux.vnet.ibm.com, stefanha@linux.vnet.ibm.com, blauwirbel@gmail.com, ohmura.kei@lab.ntt.co.jp To: Yoshiaki Tamura Return-path: Received: from mail-yw0-f46.google.com ([209.85.213.46]:36253 "EHLO mail-yw0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755133Ab1A1M6o (ORCPT ); Fri, 28 Jan 2011 07:58:44 -0500 Received: by ywe10 with SMTP id 10so1039607ywe.19 for ; Fri, 28 Jan 2011 04:58:43 -0800 (PST) In-Reply-To: <1296199312-26334-20-git-send-email-tamura.yoshiaki@lab.ntt.co.jp> Sender: kvm-owner@vger.kernel.org List-ID: On 01/28/2011 08:21 AM, Yoshiaki Tamura wrote: > > + /* check ft_mode option */ > + p = strstr(uri, "ft_mode"); > + if (p&& !strcmp(p, "ft_mode")) { > + ft_mode = FT_INIT; > + } > + This works for TCP mode, but: 1) I am not sure what would happen with -incoming exec; 2) it is tricky! :) It works only because anything after the port is truncated by parse_host_port. Is there any reason why the code cannot be in tcp_start_incoming_migration, where we know the URI has the right scheme? Alternatively you could put it _before_ the scheme, like "kemari:tcp:host:port". Paolo