* [PATCH] KVM: x86: Drop obsolete warning about INIT on runnable VCPU
@ 2011-02-01 12:27 Jan Kiszka
2011-02-03 16:21 ` Marcelo Tosatti
0 siblings, 1 reply; 2+ messages in thread
From: Jan Kiszka @ 2011-02-01 12:27 UTC (permalink / raw)
To: Avi Kivity, Marcelo Tosatti; +Cc: kvm, Gleb Natapov
This warning was once used for debugging QEMU user space. Though
uncommon, it is actually possible to send an INIT request to a running
VCPU. So better drop this warning before someone misuses it to flood
kernel logs this way.
Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
---
arch/x86/kvm/lapic.c | 4 ----
1 files changed, 0 insertions(+), 4 deletions(-)
diff --git a/arch/x86/kvm/lapic.c b/arch/x86/kvm/lapic.c
index 93cf9d0..0171e66 100644
--- a/arch/x86/kvm/lapic.c
+++ b/arch/x86/kvm/lapic.c
@@ -417,10 +417,6 @@ static int __apic_accept_irq(struct kvm_lapic *apic, int delivery_mode,
case APIC_DM_INIT:
if (level) {
result = 1;
- if (vcpu->arch.mp_state == KVM_MP_STATE_RUNNABLE)
- printk(KERN_DEBUG
- "INIT on a runnable vcpu %d\n",
- vcpu->vcpu_id);
vcpu->arch.mp_state = KVM_MP_STATE_INIT_RECEIVED;
kvm_make_request(KVM_REQ_EVENT, vcpu);
kvm_vcpu_kick(vcpu);
--
1.7.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] KVM: x86: Drop obsolete warning about INIT on runnable VCPU
2011-02-01 12:27 [PATCH] KVM: x86: Drop obsolete warning about INIT on runnable VCPU Jan Kiszka
@ 2011-02-03 16:21 ` Marcelo Tosatti
0 siblings, 0 replies; 2+ messages in thread
From: Marcelo Tosatti @ 2011-02-03 16:21 UTC (permalink / raw)
To: Jan Kiszka; +Cc: Avi Kivity, kvm, Gleb Natapov
On Tue, Feb 01, 2011 at 01:27:15PM +0100, Jan Kiszka wrote:
> This warning was once used for debugging QEMU user space. Though
> uncommon, it is actually possible to send an INIT request to a running
> VCPU. So better drop this warning before someone misuses it to flood
> kernel logs this way.
>
> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
> ---
> arch/x86/kvm/lapic.c | 4 ----
> 1 files changed, 0 insertions(+), 4 deletions(-)
Applied, thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-02-03 17:38 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-02-01 12:27 [PATCH] KVM: x86: Drop obsolete warning about INIT on runnable VCPU Jan Kiszka
2011-02-03 16:21 ` Marcelo Tosatti
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox