From mboxrd@z Thu Jan  1 00:00:00 1970
From: Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [PATCH 15/19] savevm: introduce qemu_savevm_trans_{begin,commit}.
Date: Wed, 02 Feb 2011 09:05:24 +0100
Message-ID: <4D491044.5090709@redhat.com>
References: <1296199312-26334-1-git-send-email-tamura.yoshiaki@lab.ntt.co.jp>	<1296199312-26334-16-git-send-email-tamura.yoshiaki@lab.ntt.co.jp>	<4D42C41D.7090705@redhat.com>	<AANLkTinaSgv-g+w8frLmBR_A0r+T76w7rB4QUJPqR774@mail.gmail.com> <AANLkTi==vQDpmFmiYU9-S1Zh=nZdygRMMvpJHpJN_7gR@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Cc: kvm@vger.kernel.org, qemu-devel@nongnu.org
To: Yoshiaki Tamura <tamura.yoshiaki@lab.ntt.co.jp>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mail-ww0-f44.google.com ([74.125.82.44]:35534 "EHLO
	mail-ww0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1753395Ab1BBIF2 (ORCPT <rfc822;kvm@vger.kernel.org>);
	Wed, 2 Feb 2011 03:05:28 -0500
Received: by wwa36 with SMTP id 36so7966584wwa.1
        for <kvm@vger.kernel.org>; Wed, 02 Feb 2011 00:05:27 -0800 (PST)
In-Reply-To: <AANLkTi==vQDpmFmiYU9-S1Zh=nZdygRMMvpJHpJN_7gR@mail.gmail.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On 02/01/2011 07:21 PM, Yoshiaki Tamura wrote:
> Paolo,
>
> I refactored the savevm functions.  Could you give me your
> comments?

I didn't review it thoroughly, but the abstractions seem okay.

Paolo