Re: [PATCH 19/19] migration: add a parser to accept FT migration incoming mode.

Paolo Bonzini
2011-01-28T12:58:44Z

On 01/28/2011 08:21 AM, Yoshiaki Tamura wrote:
>
> + /* check ft_mode option */
> + p = strstr(uri, "ft_mode");
> + if (p&& !strcmp(p, "ft_mode")) {
> + ft_mode = FT_INIT;
> + }
> +

This works for TCP mode, but:

1) I am not sure what would happen with -incoming exec;

2) it is tricky! :) It works only because anything after the port is
truncated by parse_host_port.

Is there any reason why the code cannot be in
tcp_start_incoming_migration, where we know the URI has the right
scheme? Alternatively you could put it _before_ the scheme, like
"kemari:tcp:host:port".

Paolo