Re: [Qemu-devel] Re: [PATCH 19/19] migration: add a parser to accept FT migration incoming mode.

Yoshiaki Tamura
2011-01-29T09:32:00Z

2011/1/29 Paolo Bonzini <pbonzini@redhat.com>:
> On 01/28/2011 04:31 PM, Yoshiaki Tamura wrote:
>>
>> That's the hack I was imaging:)
>
> So your original patch is also a hack? :)

TBH, yeah :) I didn't came up better idea that is not over
engineered.

>> Maybe this is just an issue of preference, but I'm not sure
>> adding "kemari:" to be intuitive.  If there were similar
>> extensions having the same problem, I would have agreed quickly.
>> I originally didn't have this idea, but simply adding -kemari
>> separate from -incoming isn't enough?
>
> No idea...  Only, having "migrate" on one side and something other than
> "-incoming" on the other side seems strange.

OK, then while keeping "-incoming kemari:tcp:<host>:<port>" as a
strong solution, could you please explain why placing the original
parser under tcp handler wasn't a good idea? With that,
-incoming exec .*,ft_mode shouldn't be a problem. I
chose "-incoming tcp:<host>:<port>, ft_mode" because qemu usually
take "," for specifying variants for each option (e.g. -net
nic,macaddr=). The problem was -incoming didn't have it yet.

Yoshi

>
> Paolo
> --
> To unsubscribe from this list: send the line "unsubscribe kvm" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>