Re: [PATCH 19/19] migration: add a parser to accept FT migration incoming mode.

Yoshiaki Tamura
2011-01-28T13:53:25Z

2011/1/28 Paolo Bonzini <pbonzini@redhat.com>:
> On 01/28/2011 08:21 AM, Yoshiaki Tamura wrote:
>>
>> +    /* check ft_mode option  */
>> +    p = strstr(uri, "ft_mode");
>> +    if (p&&  !strcmp(p, "ft_mode")) {
>> +        ft_mode = FT_INIT;
>> +    }
>> +
>
> This works for TCP mode, but:
>
> 1) I am not sure what would happen with -incoming exec;

Nothing happens if used with other protocols, but I assume you're
mentioning that it's not clear from the code, which makes sense.

> 2) it is tricky! :)  It works only because anything after the port is
> truncated by parse_host_port.
>
> Is there any reason why the code cannot be in tcp_start_incoming_migration,
> where we know the URI has the right scheme?  Alternatively you could put it
> _before_ the scheme, like "kemari:tcp:host:port".

I placed it here just because string parsing was mainly done in
this function except for parse_host_port. I have no objection
placing the parsing at the beginning of
tcp_start_incoming_migration.

Thanks,

Yoshi

>
> Paolo
> --
> To unsubscribe from this list: send the line "unsubscribe kvm" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>