From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH 2/2] KVM: SVM: check for progress after IRET interception Date: Thu, 03 Feb 2011 17:58:47 +0200 Message-ID: <4D4AD0B7.4090809@redhat.com> References: <1296745369-12066-1-git-send-email-avi@redhat.com> <1296745369-12066-3-git-send-email-avi@redhat.com> <4D4AC4B5.7060009@redhat.com> <4D4AC7E3.7070408@siemens.com> <4D4ACA0D.4090707@redhat.com> <4D4ACFD9.9000203@siemens.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Marcelo Tosatti , "kvm@vger.kernel.org" , Joerg Roedel To: Jan Kiszka Return-path: Received: from mx1.redhat.com ([209.132.183.28]:37347 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753283Ab1BCP7y (ORCPT ); Thu, 3 Feb 2011 10:59:54 -0500 In-Reply-To: <4D4ACFD9.9000203@siemens.com> Sender: kvm-owner@vger.kernel.org List-ID: On 02/03/2011 05:55 PM, Jan Kiszka wrote: > > > > What's an interrupt window without IRET interception? > > I don't the details, but I thought you could get something like an > interrupt-window-open interception by (fake-)injecting an IRQ and > intercepting on VIRQ acceptance. That will not work if returning to and > staying in irq-disabled guest code, therefore the timeout, but it should > be most efficient (specifically if the guest uses NMIs for things like > perf). > Since NMIs are used to break out of irq-disabled regions (watchdog, NMI IPIs during reboots) I'm wary of such a solution. -- error compiling committee.c: too many arguments to function