Re: [PATCH 0/2] Emulator intercept frameworks

Roedel, Joerg
2010-12-06T10:53:45Z

Hi Avi,

On Sun, Dec 05, 2010 at 05:18:23AM -0500, Avi Kivity wrote:
> This patchset defines a framework for intercepting emulated instructions. It
> takes a middle ground to the two previous proposals: putting everything in
> an arch callback, or putting everything in the emulator. Instead, it marks
> each interceptable instruction with an intercept code that it passes to an
> arch callback. The intercept code can then be used to index a table that
> looks up the correct VMCB bit and exit reason (for the case of SVM).

Thanks for that infrastructure work. This interface looks indeed better
than my original one. Most of the instruction decoding stuff (which was
the code duplication between the x86_emulate_insn function) can be
removed now.

> Joerg, if this looks right to you, please integrate it into your emulator
> intercept patchset.

Will do. It will probably take until January before I am done with this.
There is some other stuff to do first.

Joerg

--
AMD Operating System Research Center

Advanced Micro Devices GmbH Einsteinring 24 85609 Dornach
General Managers: Alberto Bozzo, Andrew Bowd
Registration: Dornach, Landkr. Muenchen; Registerger. Muenchen, HRB Nr. 43632