kvm.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Anthony Liguori <anthony@codemonkey.ws>
To: Avi Kivity <avi@redhat.com>
Cc: Jan Kiszka <jan.kiszka@siemens.com>,
	qemu-devel <qemu-devel@nongnu.org>,
	Glauber Costa <glommer@redhat.com>,
	Ulrich Obergfell <uobergfe@redhat.com>, kvm <kvm@vger.kernel.org>
Subject: Re: [Qemu-devel] Re: [RFC: 0/2] patch for QEMU HPET periodic timer emulation to alleviate time drift
Date: Mon, 07 Feb 2011 09:22:18 -0600	[thread overview]
Message-ID: <4D500E2A.8030003@codemonkey.ws> (raw)
In-Reply-To: <4D500AFC.4040206@redhat.com>

On 02/07/2011 09:08 AM, Avi Kivity wrote:
> On 02/07/2011 05:01 PM, Jan Kiszka wrote:
>> >
>> >  On the other hand, we need a way to inject lost ticks into a
>> >  PeriodicTimer.  If interrupt injection detects that an interrupt was
>> >  coalesced, we want the timer to schedule a new tick for us.
>>
>> Isn't absence of corresponding call to periodic_timer_ack() sufficient?
>
> It probably is.  However, that API is easy to misuse; if you forget to 
> call it, the timer goes crazy.  The default behaviour should be to 
> assume an ack and the API should provide adjustments.

I disagree.  You typically only call it in one place and as such, if you 
forget to add that call, you'll find out pretty quickly that you did 
something wrong.

OTOH, accounting missed ticks is easy to not do correctly and it's hard 
to get feedback when that happens.

>
> Also need to design the API carefully for changing frequency (Windows 
> is known to do that) and switching from periodic to single shot.  For 
> the first case I guess we need to adjust the deferred ticks to the new 
> time base (so if the frequency doubles, the lost ticks up to that 
> point double as well).  For the second case, I guess we just lose time.

Bus cycle based one shot timers probably need to be treated as a special 
case of changing an interval followed by setting the interval to zero.

For non-bus cycle based timers, it probably doesn't matter and is easy 
to just use a one shot timer (like QEMUTimer).

Regards,

Anthony Liguori


  parent reply	other threads:[~2011-02-07 15:22 UTC|newest]

Thread overview: 41+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <480481933.225059.1296734409954.JavaMail.root@zmail07.collab.prod.int.phx2.redhat.com>
2011-02-03 13:43 ` [RFC: 0/2] patch for QEMU HPET periodic timer emulation to alleviate time drift Ulrich Obergfell
2011-02-03 15:28   ` Jan Kiszka
2011-02-03 20:07     ` [Qemu-devel] " Anthony Liguori
2011-02-03 21:24       ` Jan Kiszka
2011-02-04  2:06         ` Anthony Liguori
2011-02-04  8:56           ` Jan Kiszka
2011-02-07 12:34             ` Avi Kivity
2011-02-07 13:11               ` Anthony Liguori
2011-02-07 13:14                 ` Avi Kivity
2011-02-07 13:23                   ` Anthony Liguori
2011-02-07 13:34                     ` Avi Kivity
2011-02-07 13:41                     ` Gleb Natapov
2011-02-07 13:46                       ` Avi Kivity
2011-02-07 13:48                         ` Gleb Natapov
2011-02-07 13:51                           ` Avi Kivity
2011-02-07 13:54                             ` Gleb Natapov
2011-02-07 14:10                     ` Jan Kiszka
2011-02-07 14:28                       ` Anthony Liguori
2011-02-07 14:43                         ` Jan Kiszka
2011-02-07 14:54                           ` Anthony Liguori
2011-02-07 14:57                             ` Jan Kiszka
2011-02-07 15:01                               ` Anthony Liguori
2011-02-07 15:08                                 ` Jan Kiszka
2011-02-07 15:13                                 ` Avi Kivity
2011-02-07 15:17                                   ` Jan Kiszka
2011-02-07 15:29                                     ` Avi Kivity
2011-02-07 19:30                                       ` Anthony Liguori
2011-02-08  9:11                                         ` Avi Kivity
2011-02-07 15:20                                   ` Jan Kiszka
2011-02-07 15:30                                     ` Avi Kivity
2011-02-07 19:28                                     ` Anthony Liguori
2011-02-07 14:58                             ` Avi Kivity
2011-02-07 15:01                               ` Jan Kiszka
2011-02-07 15:08                                 ` Avi Kivity
2011-02-07 15:14                                   ` Jan Kiszka
2011-02-07 15:16                                     ` Avi Kivity
2011-02-07 15:22                                   ` Anthony Liguori [this message]
2011-02-07 15:18                               ` Anthony Liguori
2011-02-04  9:52           ` Ulrich Obergfell
2011-02-07 10:44       ` Ulrich Obergfell
2011-02-07 13:24       ` Anthony Liguori

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4D500E2A.8030003@codemonkey.ws \
    --to=anthony@codemonkey.ws \
    --cc=avi@redhat.com \
    --cc=glommer@redhat.com \
    --cc=jan.kiszka@siemens.com \
    --cc=kvm@vger.kernel.org \
    --cc=qemu-devel@nongnu.org \
    --cc=uobergfe@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).