From: Avi Kivity <avi@redhat.com>
To: Jan Kiszka <jan.kiszka@siemens.com>
Cc: Zachary Amsden <zamsden@redhat.com>,
Marcelo Tosatti <mtosatti@redhat.com>, kvm <kvm@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] KVM: x86: Convert tsc_write_lock to raw_spinlock
Date: Mon, 07 Feb 2011 17:52:39 +0200 [thread overview]
Message-ID: <4D501547.6040907@redhat.com> (raw)
In-Reply-To: <4D50120F.4030809@siemens.com>
On 02/07/2011 05:38 PM, Jan Kiszka wrote:
> >
> > I don't know as it is allowed to sleep, it doesn't call any sleeping
> > functions to my knowledge. What worries me in the RT case is that the
> > spinlock acquired for hardware_enable might be preempted and run on
> > another CPU, which obviously isn't what you want.
>
> I see now, there are calls to raw_smp_processor_id.
>
> I think it's best to make this a raw lock. At this chance, some
> read-only users of vm_list should be rcu'ified. Will have a look.
vm_list is rarely used, for either read or write. I don't see the need
to rcu it.
--
error compiling committee.c: too many arguments to function
next prev parent reply other threads:[~2011-02-07 15:52 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-04 9:49 [PATCH] KVM: x86: Convert tsc_write_lock to raw_spinlock Jan Kiszka
2011-02-04 21:03 ` Zachary Amsden
2011-02-07 11:35 ` Jan Kiszka
2011-02-07 14:11 ` Zachary Amsden
2011-02-07 15:00 ` Jan Kiszka
2011-02-07 15:15 ` Zachary Amsden
2011-02-07 15:38 ` Jan Kiszka
2011-02-07 15:52 ` Avi Kivity [this message]
2011-02-07 15:58 ` Jan Kiszka
2011-02-07 16:26 ` Avi Kivity
2011-02-07 16:59 ` Jan Kiszka
2011-02-07 17:10 ` Avi Kivity
2011-02-07 17:23 ` Jan Kiszka
2011-02-08 9:15 ` Avi Kivity
2011-02-08 9:55 ` Jan Kiszka
2011-02-08 9:58 ` Avi Kivity
2011-02-10 10:40 ` Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D501547.6040907@redhat.com \
--to=avi@redhat.com \
--cc=jan.kiszka@siemens.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mtosatti@redhat.com \
--cc=zamsden@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).