From mboxrd@z Thu Jan  1 00:00:00 1970
From: Anthony Liguori <anthony@codemonkey.ws>
Subject: Re: [Qemu-devel] Re: [RFC: 0/2] patch for QEMU HPET periodic timer
 emulation to alleviate time drift
Date: Mon, 07 Feb 2011 13:28:56 -0600
Message-ID: <4D5047F8.4020308@codemonkey.ws>
References: <480481933.225059.1296734409954.JavaMail.root@zmail07.collab.prod.int.phx2.redhat.com>	<1375835067.226263.1296740625327.JavaMail.root@zmail07.collab.prod.int.phx2.redhat.com>	<4D4AC99A.2070803@siemens.com>	<4D4B0B07.2040904@codemonkey.ws>	<4D4B1CF8.8040800@web.de>	<4D4B5F23.7040801@codemonkey.ws>	<4D4BBF55.9060000@web.de>	<4D4FE6BF.5080502@redhat.com>	<4D4FEF81.1040603@codemonkey.ws>	<4D4FF02F.2030309@redhat.com>	<4D4FF24A.7000004@codemonkey.ws>	<4D4FFD3B.2030903@siemens.com>	<4D5001A0.8020503@codemonkey.ws>	<4D5004FC.80000@siemens.com>	<4D5007B9.7060806@codemonkey.ws>	<4D500872.3070506@siemens.com> <4D50092C.1080109@codemonkey.ws>	<4D500C1A.1070506@redhat.com> <4D500DC8.5060301@siemens.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Cc: Avi Kivity <avi@redhat.com>, kvm <kvm@vger.kernel.org>,
	Glauber Costa <glommer@redhat.com>,
	qemu-devel <qemu-devel@nongnu.org>,
	Ulrich Obergfell <uobergfe@redhat.com>
To: Jan Kiszka <jan.kiszka@siemens.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mail-ww0-f42.google.com ([74.125.82.42]:42750 "EHLO
	mail-ww0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1753936Ab1BGT3E (ORCPT <rfc822;kvm@vger.kernel.org>);
	Mon, 7 Feb 2011 14:29:04 -0500
Received: by wwi17 with SMTP id 17so3267951wwi.1
        for <kvm@vger.kernel.org>; Mon, 07 Feb 2011 11:29:02 -0800 (PST)
In-Reply-To: <4D500DC8.5060301@siemens.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On 02/07/2011 09:20 AM, Jan Kiszka wrote:
> On 2011-02-07 16:13, Avi Kivity wrote:
>    
>>> PeriodicTimer *periodic_timer_new(PeriodicTimerFunc *cb, void *opaque);
>>>
>>>        
>> void periodic_timer_init(PeriodicTimer *timer, PeriodicTimerFunc *cb);
>>
>> It is better to embed than to reference.
>>      
> And embedding means making the layout (at least the size) of
> PeriodicTimer public. I guess that's why QEMUTimer works via new.
>    

Yeah, QEMU generally follows a construction-is-allocation model.

Regards,

Anthony Liguori

> Jan
>
>