From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [Qemu-devel] Re: [RFC: 0/2] patch for QEMU HPET periodic timer emulation to alleviate time drift Date: Tue, 08 Feb 2011 11:11:39 +0200 Message-ID: <4D5108CB.1040405@redhat.com> References: <480481933.225059.1296734409954.JavaMail.root@zmail07.collab.prod.int.phx2.redhat.com> <1375835067.226263.1296740625327.JavaMail.root@zmail07.collab.prod.int.phx2.redhat.com> <4D4AC99A.2070803@siemens.com> <4D4B0B07.2040904@codemonkey.ws> <4D4B1CF8.8040800@web.de> <4D4B5F23.7040801@codemonkey.ws> <4D4BBF55.9060000@web.de> <4D4FE6BF.5080502@redhat.com> <4D4FEF81.1040603@codemonkey.ws> <4D4FF02F.2030309@redhat.com> <4D4FF24A.7000004@codemonkey.ws> <4D4FFD3B.2030903@siemens.com> <4D5001A0.8020503@codemonkey.ws> <4D5004FC.80000@siemens.com> <4D5007B9.7060806@codemonkey.ws> <4D500872.3070506@siemens.com> <4D50092C.1080109@codemonkey.ws> <4D500C1A.1070506@redhat.com> <4D500D08.5020709@siemens.com> <4D500FC6.2080700@redhat.com> <4D504860.3090407@codemonkey.ws> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Jan Kiszka , kvm , Glauber Costa , qemu-devel , Ulrich Obergfell To: Anthony Liguori Return-path: Received: from mx1.redhat.com ([209.132.183.28]:16998 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751902Ab1BHJLq (ORCPT ); Tue, 8 Feb 2011 04:11:46 -0500 In-Reply-To: <4D504860.3090407@codemonkey.ws> Sender: kvm-owner@vger.kernel.org List-ID: On 02/07/2011 09:30 PM, Anthony Liguori wrote: > > For the purposes of this, I think passing an opaque is better because > the signature stays the same as the existing timer callback. That > makes conversion a bit friendlier. > > I think it's better to avoid introducing stylistic changes with new > interfaces. I think they should be done separately. Suppose I convert all 100-odd QEMUTimer users to the new style? Might be a good exercise for Coccinelle. -- error compiling committee.c: too many arguments to function