From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH] KVM: x86: Convert tsc_write_lock to raw_spinlock Date: Tue, 08 Feb 2011 11:58:34 +0200 Message-ID: <4D5113CA.2050301@redhat.com> References: <4D4BCB97.6000900@siemens.com> <4D4C698A.4010201@redhat.com> <4D4FD8EE.6040009@siemens.com> <4D4FFD97.6010805@redhat.com> <4D5008F0.5060200@siemens.com> <4D500C9F.2080501@redhat.com> <4D50120F.4030809@siemens.com> <4D501547.6040907@redhat.com> <4D501698.1000507@siemens.com> <4D501D43.5060608@redhat.com> <4D5024F3.9090105@siemens.com> <4D5027A1.8000505@redhat.com> <4D502AA5.7040407@siemens.com> <4D5109CC.2030901@redhat.com> <4D511327.1020102@siemens.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit Cc: Zachary Amsden , Marcelo Tosatti , kvm , Linux Kernel Mailing List To: Jan Kiszka Return-path: In-Reply-To: <4D511327.1020102@siemens.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: kvm.vger.kernel.org On 02/08/2011 11:55 AM, Jan Kiszka wrote: > > > > Tracepoints have marginally lower overhead when disabled, and somewhat > > higher overhead when enabled. A disadvantage of tracepoints is that it > > is harder to associate an event with a vm when that event is triggered > > by a workqueue, but I don't think it matters in practice (kvm_stat > > doesn't even provide a per-vm breakdown). > > What about using the perf infrastructure for this? Besides that perf can > reuse tracepoints, maybe there is even a more efficient way of added new > stat sources. We are using the perf infrastructure for this (using tracepoints). -- error compiling committee.c: too many arguments to function