From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jan Kiszka Subject: Re: [Qemu-devel] [PATCH 22/23] x86: Fix MCA broadcast parameters for TCG case Date: Tue, 08 Feb 2011 12:42:30 +0100 Message-ID: <4D512C26.7090007@siemens.com> References: <545055b9481efad39a1207823a6954bceafe480b.1296834446.git.mtosatti@redhat.com> <20110208113905.GE16429@hall.aurel32.net> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Cc: Marcelo Tosatti , Anthony Liguori , Jan Kiszka , "qemu-devel@nongnu.org" , "kvm@vger.kernel.org" To: Aurelien Jarno Return-path: Received: from david.siemens.de ([192.35.17.14]:27653 "EHLO david.siemens.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752446Ab1BHLnK (ORCPT ); Tue, 8 Feb 2011 06:43:10 -0500 In-Reply-To: <20110208113905.GE16429@hall.aurel32.net> Sender: kvm-owner@vger.kernel.org List-ID: On 2011-02-08 12:39, Aurelien Jarno wrote: > On Fri, Feb 04, 2011 at 01:47:25PM -0200, Marcelo Tosatti wrote: >> From: Jan Kiszka >> >> When broadcasting MCEs, we need to set MCIP and RIPV in mcg_status like >> it is done for KVM. Use the symbolic constants at this chance. >> >> Signed-off-by: Jan Kiszka >> Signed-off-by: Marcelo Tosatti >> --- >> target-i386/helper.c | 4 ++-- >> 1 files changed, 2 insertions(+), 2 deletions(-) > > I don't feel very comfortable about this whole series (not in my > knowledge area), but as nobody else seems to care about 32-bit support, > I have committed this patch to master and the stable-0.14 tree. Don't worry too much. MCE support in QEMU, emulated or virtualized, is still fairly "experimental", not much to break here. And this is truly a fix. Thanks! Jan > >> diff --git a/target-i386/helper.c b/target-i386/helper.c >> index 1217452..f0c546d 100644 >> --- a/target-i386/helper.c >> +++ b/target-i386/helper.c >> @@ -1147,8 +1147,8 @@ void cpu_inject_x86_mce(CPUState *cenv, int bank, uint64_t status, >> if (cenv == env) { >> continue; >> } >> - >> - qemu_inject_x86_mce(env, 1, 0xa000000000000000, 0, 0, 0); >> + qemu_inject_x86_mce(env, 1, MCI_STATUS_VAL | MCI_STATUS_UC, >> + MCG_STATUS_MCIP | MCG_STATUS_RIPV, 0, 0); >> } >> } >> } >> -- >> 1.7.2.3 >> >> >> > -- Siemens AG, Corporate Technology, CT T DE IT 1 Corporate Competence Center Embedded Linux