kvm.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: Yoshiaki Tamura <tamura.yoshiaki@lab.ntt.co.jp>
Cc: kvm@vger.kernel.org, qemu-devel@nongnu.org, ohmura.kei@lab.ntt.co.jp
Subject: Re: [PATCH 18/18] Introduce "kemari:" to enable FT migration mode (Kemari).
Date: Thu, 10 Feb 2011 10:52:57 +0100	[thread overview]
Message-ID: <4D53B579.4070904@redhat.com> (raw)
In-Reply-To: <1297330258-20494-19-git-send-email-tamura.yoshiaki@lab.ntt.co.jp>

On 02/10/2011 10:30 AM, Yoshiaki Tamura wrote:
> When "kemari:" is set in front of URI of migrate command, it will turn
> on ft_mode to start FT migration mode (Kemari).  On the receiver side,
> the option looks like, -incoming kemari:<protocol>:<address>:<port>
>
> Signed-off-by: Yoshiaki Tamura<tamura.yoshiaki@lab.ntt.co.jp>
> ---
>   hmp-commands.hx |    4 +++-
>   migration.c     |   12 ++++++++++++
>   qmp-commands.hx |    4 +++-
>   3 files changed, 18 insertions(+), 2 deletions(-)
>
> diff --git a/hmp-commands.hx b/hmp-commands.hx
> index 38e1eb7..ee14344 100644
> --- a/hmp-commands.hx
> +++ b/hmp-commands.hx
> @@ -760,7 +760,9 @@ ETEXI
>   		      "\n\t\t\t -b for migration without shared storage with"
>   		      " full copy of disk\n\t\t\t -i for migration without "
>   		      "shared storage with incremental copy of disk "
> -		      "(base image shared between src and destination)",
> +		      "(base image shared between src and destination)"
> +		      "\n\t\t\t put \"kemari:\" in front of URI to enable "
> +		      "Fault Tolerance mode (Kemari protocol)",
>           .user_print = monitor_user_noop,	
>   	.mhandler.cmd_new = do_migrate,
>       },
> diff --git a/migration.c b/migration.c
> index 7837c55..a3f7722 100644
> --- a/migration.c
> +++ b/migration.c
> @@ -48,6 +48,12 @@ int qemu_start_incoming_migration(const char *uri)
>       const char *p;
>       int ret;
>
> +    /* check ft_mode (Kemari protocol) */
> +    if (strstart(uri, "kemari:",&p)) {
> +        ft_mode = FT_INIT;
> +        uri = p;
> +    }
> +
>       if (strstart(uri, "tcp:",&p))
>           ret = tcp_start_incoming_migration(p);
>   #if !defined(WIN32)
> @@ -99,6 +105,12 @@ int do_migrate(Monitor *mon, const QDict *qdict, QObject **ret_data)
>           return -1;
>       }
>
> +    /* check ft_mode (Kemari protocol) */
> +    if (strstart(uri, "kemari:",&p)) {
> +        ft_mode = FT_INIT;
> +        uri = p;
> +    }
> +
>       if (strstart(uri, "tcp:",&p)) {
>           s = tcp_start_outgoing_migration(mon, p, max_throttle, detach,
>                                            blk, inc);
> diff --git a/qmp-commands.hx b/qmp-commands.hx
> index df40a3d..68ca48a 100644
> --- a/qmp-commands.hx
> +++ b/qmp-commands.hx
> @@ -437,7 +437,9 @@ EQMP
>   		      "\n\t\t\t -b for migration without shared storage with"
>   		      " full copy of disk\n\t\t\t -i for migration without "
>   		      "shared storage with incremental copy of disk "
> -		      "(base image shared between src and destination)",
> +		      "(base image shared between src and destination)"
> +		      "\n\t\t\t put \"kemari:\" in front of URI to enable "
> +		      "Fault Tolerance mode (Kemari protocol)",
>           .user_print = monitor_user_noop,	
>   	.mhandler.cmd_new = do_migrate,
>       },

Acked-by: Paolo Bonzini <pbonzini@redhat.com>

Paolo

  reply	other threads:[~2011-02-10  9:53 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-02-10  9:30 [PATCH 00/18] Kemari for KVM v0.2.10 Yoshiaki Tamura
2011-02-10  9:30 ` [PATCH 01/18] Make QEMUFile buf expandable, and introduce qemu_realloc_buffer() and qemu_clear_buffer() Yoshiaki Tamura
2011-02-10  9:30 ` [PATCH 02/18] Introduce read() to FdMigrationState Yoshiaki Tamura
2011-02-10  9:54   ` [Qemu-devel] " Anthony Liguori
2011-02-10 10:00     ` Yoshiaki Tamura
2011-02-10 10:18     ` Daniel P. Berrange
2011-02-10 10:23       ` Yoshiaki Tamura
2011-02-10 10:44         ` Daniel P. Berrange
2011-02-10 10:51           ` Yoshiaki Tamura
2011-02-10  9:30 ` [PATCH 03/18] Introduce skip_header parameter to qemu_loadvm_state() Yoshiaki Tamura
2011-02-10  9:30 ` [PATCH 04/18] qemu-char: export socket_set_nodelay() Yoshiaki Tamura
2011-02-10  9:30 ` [PATCH 05/18] vl.c: add deleted flag for deleting the handler Yoshiaki Tamura
2011-02-10  9:30 ` [PATCH 06/18] virtio: decrement last_avail_idx with inuse before saving Yoshiaki Tamura
2011-02-10  9:30 ` [PATCH 07/18] Introduce fault tolerant VM transaction QEMUFile and ft_mode Yoshiaki Tamura
2011-02-21  4:46   ` ya su
2011-02-21  9:42     ` [Qemu-devel] " Yoshiaki Tamura
2011-02-23  2:28       ` ya su
2011-02-23  5:05         ` [Qemu-devel] " Yoshiaki Tamura
2011-02-10  9:30 ` [PATCH 08/18] savevm: introduce util functions to control ft_trans_file from savevm layer Yoshiaki Tamura
2011-02-10  9:30 ` [PATCH 09/18] Introduce event-tap Yoshiaki Tamura
2011-02-10  9:30 ` [PATCH 10/18] Call init handler of event-tap at main() in vl.c Yoshiaki Tamura
2011-02-10  9:30 ` [PATCH 11/18] ioport: insert event_tap_ioport() to ioport_write() Yoshiaki Tamura
2011-02-10  9:30 ` [PATCH 12/18] Insert event_tap_mmio() to cpu_physical_memory_rw() in exec.c Yoshiaki Tamura
2011-02-10  9:30 ` [PATCH 13/18] net: insert event-tap to qemu_send_packet() and qemu_sendv_packet_async() Yoshiaki Tamura
2011-02-10  9:30 ` [PATCH 14/18] block: insert event-tap to bdrv_aio_writev(), bdrv_aio_flush() and bdrv_flush() Yoshiaki Tamura
2011-02-10  9:30 ` [PATCH 15/18] savevm: introduce qemu_savevm_trans_{begin,commit} Yoshiaki Tamura
2011-02-10  9:30 ` [PATCH 16/18] migration: introduce migrate_ft_trans_{put,get}_ready(), and modify migrate_fd_put_ready() when ft_mode is on Yoshiaki Tamura
2011-02-10  9:30 ` [PATCH 17/18] migration-tcp: modify tcp_accept_incoming_migration() to handle ft_mode, and add a hack not to close fd when ft_mode is enabled Yoshiaki Tamura
2011-02-10  9:30 ` [PATCH 18/18] Introduce "kemari:" to enable FT migration mode (Kemari) Yoshiaki Tamura
2011-02-10  9:52   ` Paolo Bonzini [this message]
  -- strict thread matches above, loose matches on Subject: below --
2011-02-23 13:48 [PATCH 00/18] Kemari for KVM v0.2.11 Yoshiaki Tamura
2011-02-23 13:48 ` [PATCH 18/18] Introduce "kemari:" to enable FT migration mode (Kemari) Yoshiaki Tamura
2011-02-24  7:28 [PATCH 00/18] Kemari for KVM v0.2.12 Yoshiaki Tamura
2011-02-24  7:28 ` [PATCH 18/18] Introduce "kemari:" to enable FT migration mode (Kemari) Yoshiaki Tamura
2011-03-23  4:10 [PATCH 00/18] [PATCH 00/18] Kemari for KVM v0.2.13 Yoshiaki Tamura
2011-03-23  4:10 ` [PATCH 18/18] Introduce "kemari:" to enable FT migration mode (Kemari) Yoshiaki Tamura
2011-04-25 11:00 [PATCH 00/18] Kemari for KVM v0.2.14 OHMURA Kei
2011-04-25 11:00 ` [PATCH 18/18] Introduce "kemari:" to enable FT migration mode (Kemari) OHMURA Kei

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4D53B579.4070904@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=kvm@vger.kernel.org \
    --cc=ohmura.kei@lab.ntt.co.jp \
    --cc=qemu-devel@nongnu.org \
    --cc=tamura.yoshiaki@lab.ntt.co.jp \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).