Re: [KVM-AUTOTEST PATCH] KVM test: refactor kvm_config.py

Lucas Meneghel Rodrigues
2011-02-10T12:42:44Z

On Thu, 2011-02-10 at 09:18 +0800, Amos Kong wrote:
> On Wed, Feb 09, 2011 at 11:28:56AM +0200, Avi Kivity wrote:
> > On 02/09/2011 03:50 AM, Michael Goldish wrote:
> > >This is a reimplementation of the dict generator. It is much faster than the
> > >current implementation and uses a very small amount of memory. Running time
> > >and memory usage scale polynomially with the number of defined variants,
> > >compared to exponentially in the current implementation.
> > >
> > >Instead of regular expressions in the filters, the following syntax is used:
> > >
> > >, means OR
> > >.. means AND
> > >. means IMMEDIATELY-FOLLOWED-BY
> > >
> > >Example:
> > >
> > >only qcow2..Fedora.14, RHEL.6..raw..boot, smp2..qcow2..migrate..ide
> > >
> >
> >
> > Is it not possible to keep the old syntax? Breaking people's
> > scripts is bad.
>
> we only need convert the configure file, it's not too complex

Yes, the benefits of the new format outnumber the inconveniences. As for
my opinion on the operator, .. is sufficiently clear and expressive to
do most of the stuff we need to do with configuration anyway.