From: Jan Kiszka <jan.kiszka@siemens.com>
To: Marcelo Tosatti <mtosatti@redhat.com>
Cc: Avi Kivity <avi@redhat.com>, kvm <kvm@vger.kernel.org>,
Zachary Amsden <zamsden@redhat.com>
Subject: Re: [PATCH 2/2] KVM: Convert read-only users of vm_list to RCU
Date: Tue, 15 Feb 2011 15:08:12 +0100 [thread overview]
Message-ID: <4D5A88CC.8020707@siemens.com> (raw)
In-Reply-To: <20110215123202.GA3731@amt.cnet>
On 2011-02-15 13:32, Marcelo Tosatti wrote:
> On Tue, Feb 08, 2011 at 12:55:39PM +0100, Jan Kiszka wrote:
>> Only for walking the list of VMs, we do not need to hold the preemption
>> disabling kvm_lock. Convert stat services, the cpufreq callback and
>> mmu_shrink to RCU. For the latter, special care is required to
>> synchronize its list_move_tail with kvm_destroy_vm.
>>
>> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
>
> Jan,
>
> What is the motivation for this change?
>
See http://thread.gmane.org/gmane.linux.kernel/1097043
However, this proposal turned out to be incorrect. The strategy is now
to remove the stats users and reduce the lock-holding time of mmu_shrink
differently.
Jan
--
Siemens AG, Corporate Technology, CT T DE IT 1
Corporate Competence Center Embedded Linux
prev parent reply other threads:[~2011-02-15 14:08 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <4D512EF7.8040409@siemens.com>
2011-02-08 11:55 ` [PATCH 2/2] KVM: Convert read-only users of vm_list to RCU Jan Kiszka
2011-02-10 10:16 ` Avi Kivity
2011-02-10 11:31 ` Jan Kiszka
2011-02-10 12:34 ` Avi Kivity
2011-02-10 12:45 ` Jan Kiszka
2011-02-10 12:56 ` Avi Kivity
2011-02-10 12:57 ` Avi Kivity
2011-02-10 13:14 ` Jan Kiszka
2011-02-10 13:19 ` Avi Kivity
2011-02-10 13:47 ` Jan Kiszka
2011-02-10 14:26 ` Avi Kivity
2011-02-10 14:34 ` Jan Kiszka
2011-02-10 14:47 ` Avi Kivity
2011-02-10 14:55 ` Jan Kiszka
2011-02-15 12:32 ` Marcelo Tosatti
2011-02-15 14:08 ` Jan Kiszka [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D5A88CC.8020707@siemens.com \
--to=jan.kiszka@siemens.com \
--cc=avi@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=mtosatti@redhat.com \
--cc=zamsden@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox