From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [Qemu-devel] KVM call minutes for Feb 15 Date: Thu, 17 Feb 2011 14:23:27 +0200 Message-ID: <4D5D133F.4050801@redhat.com> References: <20110215162629.GN21720@x200.localdomain> <4D5B0889.4030303@codemonkey.ws> <4D5BA5E9.90307@redhat.com> <4D5BD259.3080804@codemonkey.ws> <4D5CE9AB.2030503@redhat.com> <4D5D10C1.9010209@codemonkey.ws> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Chris Wright , qemu-devel@nongnu.org, kvm@vger.kernel.org To: Anthony Liguori Return-path: Received: from mx1.redhat.com ([209.132.183.28]:32116 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753645Ab1BQMXd (ORCPT ); Thu, 17 Feb 2011 07:23:33 -0500 In-Reply-To: <4D5D10C1.9010209@codemonkey.ws> Sender: kvm-owner@vger.kernel.org List-ID: On 02/17/2011 02:12 PM, Anthony Liguori wrote: >> (btw what happens in a non-UTF-8 locale? I guess we should just >> reject unencodable strings). > > > While QEMU is mostly ASCII internally, for the purposes of the JSON > parser, we always encode and decode UTF-8. We reject invalid UTF-8 > sequences. But since JSON is string-encoded unicode, we can always > decode a JSON string to valid UTF-8 as long as the string is well formed. That is wrong. If the user passes a Unicode filename it is expected to be translated to the current locale encoding for the purpose of, say, filename lookup. -- error compiling committee.c: too many arguments to function