From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jan Kiszka Subject: Re: [PATCH 09/13] kvm: x86: Consolidate TCG and KVM MCE injection code Date: Thu, 17 Feb 2011 19:17:04 +0100 Message-ID: <4D5D6620.4030008@siemens.com> References: <67f48a7cb1aebebb1dc4af0f413379686dcff24b.1297758211.git.jan.kiszka@siemens.com> <20110217180858.GB12113@amt.cnet> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: Avi Kivity , "kvm@vger.kernel.org" , "qemu-devel@nongnu.org" , Huang Ying , Hidetoshi Seto , Jin Dongming To: Marcelo Tosatti Return-path: Received: from david.siemens.de ([192.35.17.14]:24041 "EHLO david.siemens.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757093Ab1BQSR2 (ORCPT ); Thu, 17 Feb 2011 13:17:28 -0500 In-Reply-To: <20110217180858.GB12113@amt.cnet> Sender: kvm-owner@vger.kernel.org List-ID: On 2011-02-17 19:08, Marcelo Tosatti wrote: > On Tue, Feb 15, 2011 at 09:23:33AM +0100, Jan Kiszka wrote: >> This switches KVM's MCE injection path to cpu_x86_inject_mce, both for >> SIGBUS and monitor initiated events. This means we prepare the MCA MSRs >> in the VCPUState also for KVM. >> >> We have to drop the MSRs writeback restrictions for this purpose which >> is now safe as every uncoordinated MSR injection is removed with this >> patch. >> >> We have to execute every per-VCPU event setup on the target VCPU as we >> are performing a read-modify-write on its state. >> >> Signed-off-by: Jan Kiszka >> CC: Huang Ying >> CC: Hidetoshi Seto >> CC: Jin Dongming > > Difficult to review, please split: > > - drop writeback restriction That will not work due to mutual dependency (see changelog)... > - unify monitor/sigbus injection paths > - cleanup / refactor > ...but I will check again and filter out potential cleanups that could be done afterwards. Jan -- Siemens AG, Corporate Technology, CT T DE IT 1 Corporate Competence Center Embedded Linux