* [PATCH] kvm,async_pf: add missing kvm_async_pf_hash_reset()
@ 2011-02-21 3:21 Lai Jiangshan
2011-02-21 3:24 ` Lai Jiangshan
2011-02-27 16:21 ` Avi Kivity
0 siblings, 2 replies; 4+ messages in thread
From: Lai Jiangshan @ 2011-02-21 3:21 UTC (permalink / raw)
To: kvm@vger.kernel.org, Avi Kivity, Marcelo Tosatti, Gleb Natapov
The hash array of async gfns may still contain some left gfns after
kvm_clear_async_pf_completion_queue() called, need to clear them.
diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c
index 17af71d..dae2d15 100644
--- a/arch/x86/kvm/x86.c
+++ b/arch/x86/kvm/x86.c
@@ -525,8 +525,10 @@ int kvm_set_cr0(struct kvm_vcpu *vcpu, unsigned long cr0)
kvm_x86_ops->set_cr0(vcpu, cr0);
- if ((cr0 ^ old_cr0) & X86_CR0_PG)
+ if ((cr0 ^ old_cr0) & X86_CR0_PG) {
kvm_clear_async_pf_completion_queue(vcpu);
+ kvm_async_pf_hash_reset(vcpu);
+ }
if ((cr0 ^ old_cr0) & update_bits)
kvm_mmu_reset_context(vcpu);
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] kvm,async_pf: add missing kvm_async_pf_hash_reset()
2011-02-21 3:21 [PATCH] kvm,async_pf: add missing kvm_async_pf_hash_reset() Lai Jiangshan
@ 2011-02-21 3:24 ` Lai Jiangshan
2011-02-23 13:22 ` Gleb Natapov
2011-02-27 16:21 ` Avi Kivity
1 sibling, 1 reply; 4+ messages in thread
From: Lai Jiangshan @ 2011-02-21 3:24 UTC (permalink / raw)
To: kvm@vger.kernel.org, Avi Kivity, Marcelo Tosatti, Gleb Natapov
On 02/21/2011 11:21 AM, Lai Jiangshan wrote:
>
> The hash array of async gfns may still contain some left gfns after
> kvm_clear_async_pf_completion_queue() called, need to clear them.
>
sorry.
Signed-off-by: Lai Jiangshan <laijs@cn.fujitsu.com>
> diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c
> index 17af71d..dae2d15 100644
> --- a/arch/x86/kvm/x86.c
> +++ b/arch/x86/kvm/x86.c
> @@ -525,8 +525,10 @@ int kvm_set_cr0(struct kvm_vcpu *vcpu, unsigned long cr0)
>
> kvm_x86_ops->set_cr0(vcpu, cr0);
>
> - if ((cr0 ^ old_cr0) & X86_CR0_PG)
> + if ((cr0 ^ old_cr0) & X86_CR0_PG) {
> kvm_clear_async_pf_completion_queue(vcpu);
> + kvm_async_pf_hash_reset(vcpu);
> + }
>
> if ((cr0 ^ old_cr0) & update_bits)
> kvm_mmu_reset_context(vcpu);
> --
> To unsubscribe from this list: send the line "unsubscribe kvm" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] kvm,async_pf: add missing kvm_async_pf_hash_reset()
2011-02-21 3:24 ` Lai Jiangshan
@ 2011-02-23 13:22 ` Gleb Natapov
0 siblings, 0 replies; 4+ messages in thread
From: Gleb Natapov @ 2011-02-23 13:22 UTC (permalink / raw)
To: Lai Jiangshan; +Cc: kvm@vger.kernel.org, Avi Kivity, Marcelo Tosatti
On Mon, Feb 21, 2011 at 11:24:50AM +0800, Lai Jiangshan wrote:
> On 02/21/2011 11:21 AM, Lai Jiangshan wrote:
> >
> > The hash array of async gfns may still contain some left gfns after
> > kvm_clear_async_pf_completion_queue() called, need to clear them.
> >
>
> sorry.
>
> Signed-off-by: Lai Jiangshan <laijs@cn.fujitsu.com>
>
Acked-by: Gleb Natapov <gleb@redhat.com>
> > diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c
> > index 17af71d..dae2d15 100644
> > --- a/arch/x86/kvm/x86.c
> > +++ b/arch/x86/kvm/x86.c
> > @@ -525,8 +525,10 @@ int kvm_set_cr0(struct kvm_vcpu *vcpu, unsigned long cr0)
> >
> > kvm_x86_ops->set_cr0(vcpu, cr0);
> >
> > - if ((cr0 ^ old_cr0) & X86_CR0_PG)
> > + if ((cr0 ^ old_cr0) & X86_CR0_PG) {
> > kvm_clear_async_pf_completion_queue(vcpu);
> > + kvm_async_pf_hash_reset(vcpu);
> > + }
> >
> > if ((cr0 ^ old_cr0) & update_bits)
> > kvm_mmu_reset_context(vcpu);
> > --
> > To unsubscribe from this list: send the line "unsubscribe kvm" in
> > the body of a message to majordomo@vger.kernel.org
> > More majordomo info at http://vger.kernel.org/majordomo-info.html
> >
--
Gleb.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] kvm,async_pf: add missing kvm_async_pf_hash_reset()
2011-02-21 3:21 [PATCH] kvm,async_pf: add missing kvm_async_pf_hash_reset() Lai Jiangshan
2011-02-21 3:24 ` Lai Jiangshan
@ 2011-02-27 16:21 ` Avi Kivity
1 sibling, 0 replies; 4+ messages in thread
From: Avi Kivity @ 2011-02-27 16:21 UTC (permalink / raw)
To: Lai Jiangshan; +Cc: kvm@vger.kernel.org, Marcelo Tosatti, Gleb Natapov
On 02/21/2011 05:21 AM, Lai Jiangshan wrote:
> The hash array of async gfns may still contain some left gfns after
> kvm_clear_async_pf_completion_queue() called, need to clear them.
Applied, thanks.
--
error compiling committee.c: too many arguments to function
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2011-02-27 16:21 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-02-21 3:21 [PATCH] kvm,async_pf: add missing kvm_async_pf_hash_reset() Lai Jiangshan
2011-02-21 3:24 ` Lai Jiangshan
2011-02-23 13:22 ` Gleb Natapov
2011-02-27 16:21 ` Avi Kivity
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).