From mboxrd@z Thu Jan 1 00:00:00 1970 From: klondike Subject: Re: [ANNOUNCE] qemu-kvm-0.14.0 Date: Wed, 23 Feb 2011 09:05:37 +0100 Message-ID: <4D64BFD1.2020602@gmail.com> References: <4D63EF01.5040203@redhat.com> <20110223074948.GA7608@pcnci.linuxbox.cz> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enig425FFD73A770FF2B6DA5A395" Cc: kvm@vger.kernel.org To: Nikola Ciprich Return-path: Received: from mail-fx0-f46.google.com ([209.85.161.46]:56151 "EHLO mail-fx0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754140Ab1BWIFh (ORCPT ); Wed, 23 Feb 2011 03:05:37 -0500 Received: by fxm17 with SMTP id 17so3639215fxm.19 for ; Wed, 23 Feb 2011 00:05:36 -0800 (PST) In-Reply-To: <20110223074948.GA7608@pcnci.linuxbox.cz> Sender: kvm-owner@vger.kernel.org List-ID: This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig425FFD73A770FF2B6DA5A395 Content-Type: multipart/mixed; boundary="------------040900040909040206030803" This is a multi-part message in MIME format. --------------040900040909040206030803 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable El 23/02/11 08:49, Nikola Ciprich escribi=F3: > Hello Avi, Hi, > when trying to compile(link) various targets, I get: > LINK sparc-softmmu/qemu-system-sparc > pci-stub.o: In function `do_pci_info_print': > /usr/src/redhat/BUILD/qemu-kvm-0.14.0/hw/pci-stub.c:36: multiple defini= tion of `do_pci_info_print' > pci.o:/usr/src/redhat/BUILD/qemu-kvm-0.14.0/hw/pci.c:1398: first define= d here > /usr/bin/ld: Warning: size of symbol `do_pci_info_print' changed from 1= 47 in pci.o to 50 in pci-stub.o > pci-stub.o: In function `do_pci_info': > /usr/src/redhat/BUILD/qemu-kvm-0.14.0/hw/pci-stub.c:31: multiple defini= tion of `do_pci_info' > pci.o:/usr/src/redhat/BUILD/qemu-kvm-0.14.0/hw/pci.c:1560: first define= d here > /usr/bin/ld: Warning: size of symbol `do_pci_info' changed from 150 in = pci.o to 50 in pci-stub.o > pci.o: In function `pci_update_mappings': > pci.c:(.text+0xa91): undefined reference to `pci_bridge_get_base' > pci.c:(.text+0xaa5): undefined reference to `pci_bridge_get_limit' > pci.c:(.text+0xb7b): undefined reference to `pci_bridge_get_base' > pci.c:(.text+0xb8e): undefined reference to `pci_bridge_get_limit' > pci.o: In function `pci_get_devices_list': > pci.c:(.text+0x2024): undefined reference to `pci_bridge_get_limit' > pci.c:(.text+0x2036): undefined reference to `pci_bridge_get_base' > pci.c:(.text+0x2043): undefined reference to `pci_bridge_get_limit' > pci.c:(.text+0x2050): undefined reference to `pci_bridge_get_base' > pci.c:(.text+0x2060): undefined reference to `pci_bridge_get_limit' > pci.c:(.text+0x2070): undefined reference to `pci_bridge_get_base' > collect2: ld returned 1 exit status > make[1]: *** [qemu-system-sparc] Error 1 > make: *** [subdir-sparc-softmmu] Error 2 I hit this problem too and after a long night I tracked it back to some odd merge, this patch solved the issue for me. --------------040900040909040206030803 Content-Type: text/plain; name="qemu-kvm-0.14-fix-nopci-build-system.patch" Content-Transfer-Encoding: quoted-printable Content-Disposition: attachment; filename="qemu-kvm-0.14-fix-nopci-build-system.patch" 2010-11-10 Francisco Blas Izquierdo Riera Somehow pci.o was added so it was needed on all targets breaking NO_PCI= ones. This patch intends to fix that * Makefile.objs: Add pci.o back into hw-obj-$(CONFIG_PCI) * Makefile.target: Remove pci.o diff -ru /tmp/aaa/qemu-kvm-0.14.0.old/Makefile.objs /tmp/aaa/qemu-kvm-0.1= 4.0/Makefile.objs --- /tmp/aaa/qemu-kvm-0.14.0.old/Makefile.objs 2011-02-23 06:02:16.818182= 597 +0100 +++ /tmp/aaa/qemu-kvm-0.14.0/Makefile.objs 2011-02-23 06:00:35.439182597 = +0100 @@ -170,7 +170,7 @@ hw-obj-y +=3D loader.o hw-obj-$(CONFIG_VIRTIO) +=3D virtio.o virtio-console.o hw-obj-y +=3D fw_cfg.o -hw-obj-$(CONFIG_PCI) +=3D pci_bridge.o +hw-obj-$(CONFIG_PCI) +=3D pci.o pci_bridge.o hw-obj-$(CONFIG_PCI) +=3D msix.o msi.o hw-obj-$(CONFIG_PCI) +=3D pci_host.o pcie_host.o hw-obj-$(CONFIG_PCI) +=3D ioh3420.o xio3130_upstream.o xio3130_downstrea= m.o diff -ru /tmp/aaa/qemu-kvm-0.14.0.old/Makefile.target /tmp/aaa/qemu-kvm-0= =2E14.0/Makefile.target --- /tmp/aaa/qemu-kvm-0.14.0.old/Makefile.target 2011-02-23 06:02:16.8351= 82597 +0100 +++ /tmp/aaa/qemu-kvm-0.14.0/Makefile.target 2011-02-23 06:00:35.45418259= 7 +0100 @@ -195,7 +195,7 @@ # System emulator target ifdef CONFIG_SOFTMMU =20 -obj-y =3D arch_init.o cpus.o monitor.o pci.o machine.o gdbstub.o vl.o ba= lloon.o +obj-y =3D arch_init.o cpus.o monitor.o machine.o gdbstub.o vl.o balloon.= o # virtio has to be here due to weird dependency between PCI and virtio-n= et. # need to fix this properly obj-$(CONFIG_NO_PCI) +=3D pci-stub.o --------------040900040909040206030803-- --------------enig425FFD73A770FF2B6DA5A395 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.17 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iEYEARECAAYFAk1kv9cACgkQcfrM1mX4BmCmsgCgz7EWcU3oHieUHW4RXfKKVlQy KYoAoLIg1RAIyteuGGMHAEgyy+hQmchX =7h6q -----END PGP SIGNATURE----- --------------enig425FFD73A770FF2B6DA5A395--