From mboxrd@z Thu Jan 1 00:00:00 1970 From: klondike Subject: Re: [PATCH] qemu-kvm: Fix non-PCI target build Date: Wed, 23 Feb 2011 09:37:43 +0100 Message-ID: <4D64C757.2070907@gmail.com> References: <4D63EF01.5040203@redhat.com> <20110223074948.GA7608@pcnci.linuxbox.cz> <4D64BFD1.2020602@gmail.com> <4D64C545.3020205@siemens.com> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enig0577F9586050E3BCC44E188A" Cc: Nikola Ciprich , kvm@vger.kernel.org, Avi Kivity , Marcelo Tosatti To: Jan Kiszka Return-path: Received: from mail-fx0-f46.google.com ([209.85.161.46]:51569 "EHLO mail-fx0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755139Ab1BWInS (ORCPT ); Wed, 23 Feb 2011 03:43:18 -0500 Received: by fxm17 with SMTP id 17so3667255fxm.19 for ; Wed, 23 Feb 2011 00:43:17 -0800 (PST) In-Reply-To: <4D64C545.3020205@siemens.com> Sender: kvm-owner@vger.kernel.org List-ID: This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig0577F9586050E3BCC44E188A Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable El 23/02/11 09:28, Jan Kiszka escribi=F3: > On 2011-02-23 09:05, klondike wrote: >> El 23/02/11 08:49, Nikola Ciprich escribi=F3: >>> Hello Avi, >> Hi, >>> when trying to compile(link) various targets, I get: >>> LINK sparc-softmmu/qemu-system-sparc >>> pci-stub.o: In function `do_pci_info_print': >>> /usr/src/redhat/BUILD/qemu-kvm-0.14.0/hw/pci-stub.c:36: multiple defi= nition of `do_pci_info_print' >>> pci.o:/usr/src/redhat/BUILD/qemu-kvm-0.14.0/hw/pci.c:1398: first defi= ned here >>> /usr/bin/ld: Warning: size of symbol `do_pci_info_print' changed from= 147 in pci.o to 50 in pci-stub.o >>> pci-stub.o: In function `do_pci_info': >>> /usr/src/redhat/BUILD/qemu-kvm-0.14.0/hw/pci-stub.c:31: multiple defi= nition of `do_pci_info' >>> pci.o:/usr/src/redhat/BUILD/qemu-kvm-0.14.0/hw/pci.c:1560: first defi= ned here >>> /usr/bin/ld: Warning: size of symbol `do_pci_info' changed from 150 i= n pci.o to 50 in pci-stub.o >>> pci.o: In function `pci_update_mappings': >>> pci.c:(.text+0xa91): undefined reference to `pci_bridge_get_base' >>> pci.c:(.text+0xaa5): undefined reference to `pci_bridge_get_limit' >>> pci.c:(.text+0xb7b): undefined reference to `pci_bridge_get_base' >>> pci.c:(.text+0xb8e): undefined reference to `pci_bridge_get_limit' >>> pci.o: In function `pci_get_devices_list': >>> pci.c:(.text+0x2024): undefined reference to `pci_bridge_get_limit' >>> pci.c:(.text+0x2036): undefined reference to `pci_bridge_get_base' >>> pci.c:(.text+0x2043): undefined reference to `pci_bridge_get_limit' >>> pci.c:(.text+0x2050): undefined reference to `pci_bridge_get_base' >>> pci.c:(.text+0x2060): undefined reference to `pci_bridge_get_limit' >>> pci.c:(.text+0x2070): undefined reference to `pci_bridge_get_base' >>> collect2: ld returned 1 exit status >>> make[1]: *** [qemu-system-sparc] Error 1 >>> make: *** [subdir-sparc-softmmu] Error 2 >> I hit this problem too and after a long night I tracked it back to som= e >> odd merge, this patch solved the issue for me. > This unfortunately breaks the build with device assignment enabled. > Patch below is required. > > Generally, I would recommend to avoid using the qemu-kvm tree for > anything else than x86 with kvm support. Other use cases ought to work > but are rarely tested. Better pick upstream qemu in this case until we > reduced the diffs between both trees to a much smaller amount. > qemu-kvm-0.15 may become a milestone in this regard. > > Jan Thanks Jan, Gentoo users have little to no choice until as the qemu and qemu-kvm ebuilds block each other (so it is impossible to install both at the same time). I'll send this patch to the bump request in the gentoo bugzilla if you agree :D klondike --------------enig0577F9586050E3BCC44E188A Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.17 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iEYEARECAAYFAk1kx1sACgkQcfrM1mX4BmDwYQCgm5MUS5SLEoB11HX+P9BBrtKg 46wAnjfK/ptL6Y70eS3fPCNsT7HNWA+/ =zcx1 -----END PGP SIGNATURE----- --------------enig0577F9586050E3BCC44E188A--