From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jan Kiszka Subject: Re: Q: status of kvm/ subdir in qemu-kvm tarball? Date: Wed, 23 Feb 2011 12:31:20 +0100 Message-ID: <4D64F008.7050308@siemens.com> References: <4D64E9C6.8000505@msgid.tls.msk.ru> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: KVM list To: Michael Tokarev Return-path: Received: from goliath.siemens.de ([192.35.17.28]:15161 "EHLO goliath.siemens.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752830Ab1BWLb1 (ORCPT ); Wed, 23 Feb 2011 06:31:27 -0500 In-Reply-To: <4D64E9C6.8000505@msgid.tls.msk.ru> Sender: kvm-owner@vger.kernel.org List-ID: On 2011-02-23 12:04, Michael Tokarev wrote: > What's the current status of files in kvm/ subdirectory > in the qemu-kvm distribution (0.14 or git) ? > > As far as I can see, all that is old and unused stuff, > which only confuses users. It is not used during build > the Makefiles are obsolete and refers to non-existed > files/directories, some remaining bits (like vgabios) > are too old to be useful for current qemu-kvm, etc. > > Maybe it's better to just drop the whole thing to stop > confusion? > > If it may be needed in the future, it can be taken from > older source tarballs. Just letting that stuff to bitrot > isn't a nice thing to do. ;) > > I mentioned this yesterday to Avi (my question was > especially about vgabios), and he told me to send a > patch with justification. But it's way too simpler > to just do `git rm -r kvm' than apply a patch to > remove the whole thing. I think there are a few bits still in use: - kvm/kvm_stat - kvm/include (latest kernel headers) *) Otherwise, removing this cruft would be good. Jan *) This should really be discussed upstream again: Carry private copy of kvm headers or rely on distro / kvm-kmod to provide required defines, types etc.? I'm more and more in favor of option 1. -- Siemens AG, Corporate Technology, CT T DE IT 1 Corporate Competence Center Embedded Linux