From: Avi Kivity <avi@redhat.com>
To: Alex Williamson <alex.williamson@redhat.com>
Cc: Marcelo Tosatti <mtosatti@redhat.com>,
Jan Kiszka <jan.kiszka@siemens.com>,
"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
"ddutile@redhat.com" <ddutile@redhat.com>,
"mst@redhat.com" <mst@redhat.com>,
"chrisw@redhat.com" <chrisw@redhat.com>
Subject: Re: [RFC PATCH 0/2] Expose available KVM free memory slot count to help avoid aborts
Date: Thu, 24 Feb 2011 14:37:47 +0200 [thread overview]
Message-ID: <4D66511B.2000300@redhat.com> (raw)
In-Reply-To: <4D66506A.3030203@redhat.com>
On 02/24/2011 02:34 PM, Avi Kivity wrote:
>
> Hmm, your patch dereferences kvm->memslots without rcu_dereference().
> That's a mortal (as in oops) sin.
Sorry, that's wrong, all those places are under ->slots_lock.
> Note that sticking an rcu_dereference() blindly may or may not work
> - we might end up using information from two different generations of
> kvm->memslots, and using inconsistent data.
>
This may still hold.
--
error compiling committee.c: too many arguments to function
next prev parent reply other threads:[~2011-02-24 12:37 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-21 23:48 [RFC PATCH 0/2] Expose available KVM free memory slot count to help avoid aborts Alex Williamson
2011-01-21 23:48 ` [RFC PATCH 1/2] kvm: Allow querying free slots Alex Williamson
2011-01-21 23:48 ` [RFC PATCH 2/2] device-assignment: Count required kvm memory slots Alex Williamson
2011-01-22 22:11 ` [RFC PATCH 0/2] Expose available KVM free memory slot count to help avoid aborts Michael S. Tsirkin
2011-01-24 9:32 ` Marcelo Tosatti
2011-01-24 14:16 ` Jan Kiszka
2011-01-24 15:44 ` Alex Williamson
2011-01-25 5:37 ` Alex Williamson
2011-01-25 7:36 ` Jan Kiszka
2011-01-25 14:41 ` Alex Williamson
2011-01-25 14:45 ` Michael S. Tsirkin
2011-01-25 14:54 ` Avi Kivity
2011-01-25 14:53 ` Avi Kivity
2011-01-25 14:59 ` Michael S. Tsirkin
2011-01-25 17:33 ` Avi Kivity
2011-01-25 17:58 ` Michael S. Tsirkin
2011-01-26 9:17 ` Avi Kivity
2011-01-26 9:20 ` Michael S. Tsirkin
2011-01-26 9:23 ` Avi Kivity
2011-01-26 9:39 ` Michael S. Tsirkin
2011-01-26 9:54 ` Avi Kivity
2011-01-26 12:08 ` Michael S. Tsirkin
2011-01-27 9:21 ` Avi Kivity
2011-01-27 9:26 ` Michael S. Tsirkin
2011-01-27 9:28 ` Avi Kivity
2011-01-27 9:29 ` Michael S. Tsirkin
2011-01-27 9:51 ` Avi Kivity
2011-01-27 9:28 ` Michael S. Tsirkin
2011-01-25 16:35 ` Jan Kiszka
2011-01-25 19:13 ` Alex Williamson
2011-01-26 8:14 ` Jan Kiszka
2011-01-25 10:23 ` Avi Kivity
2011-01-25 14:57 ` Alex Williamson
2011-01-25 17:11 ` Avi Kivity
2011-01-25 17:43 ` Alex Williamson
2011-01-26 9:22 ` Avi Kivity
2011-01-31 19:18 ` Marcelo Tosatti
2011-02-23 21:46 ` Alex Williamson
2011-02-24 12:34 ` Avi Kivity
2011-02-24 12:37 ` Avi Kivity [this message]
2011-02-24 18:10 ` Alex Williamson
2011-01-25 10:20 ` Avi Kivity
2011-01-25 14:46 ` Alex Williamson
2011-01-25 14:56 ` Avi Kivity
2011-01-25 14:55 ` Michael S. Tsirkin
2011-01-25 14:58 ` Avi Kivity
2011-01-25 15:23 ` Michael S. Tsirkin
2011-01-25 17:34 ` Avi Kivity
2011-01-25 18:00 ` Michael S. Tsirkin
2011-01-26 9:25 ` Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D66511B.2000300@redhat.com \
--to=avi@redhat.com \
--cc=alex.williamson@redhat.com \
--cc=chrisw@redhat.com \
--cc=ddutile@redhat.com \
--cc=jan.kiszka@siemens.com \
--cc=kvm@vger.kernel.org \
--cc=mst@redhat.com \
--cc=mtosatti@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).