From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH] stop and show registers on error. Date: Thu, 24 Feb 2011 18:20:24 +0200 Message-ID: <4D668548.3040807@redhat.com> References: <20110221101654.GJ14984@redhat.com> <4D625973.5020405@redhat.com> <20110221122554.GK14984@redhat.com> <4D62603B.2020709@siemens.com> <20110221125757.GM14984@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Jan Kiszka , mtosatti@redhat.com, kvm@vger.kernel.org To: Gleb Natapov Return-path: Received: from mx1.redhat.com ([209.132.183.28]:9377 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754775Ab1BXQUc (ORCPT ); Thu, 24 Feb 2011 11:20:32 -0500 In-Reply-To: <20110221125757.GM14984@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On 02/21/2011 02:57 PM, Gleb Natapov wrote: > > > > FWIW, this patch just aligns qemu-kvm to what upstream already does and > > what qemu-kvm will soon or later do as well when it starts using the > > upstream loop. I'm neutral /wrt applying this patch before the cleanup > > or achieving the same by consolidating the code. > > > Indeed. When I got no register dump on error I stared at the wrong code > for 20 minutes trying to understand how it could happen. Having two kvm > implementations in the same tree is such fun! Very well, patch applied. -- error compiling committee.c: too many arguments to function