From: Avi Kivity <avi@redhat.com>
To: Prasad Joshi <prasadjoshi124@gmail.com>
Cc: kvm@vger.kernel.org
Subject: Re: [RESEND] [PATCH 1/1] qemu-kvm (device-assignment): detecting the pre-fectchable memory region.
Date: Sun, 27 Feb 2011 14:31:33 +0200 [thread overview]
Message-ID: <4D6A4425.6000509@redhat.com> (raw)
In-Reply-To: <AANLkTimdtAUZ1jsDtB5-hsWyQg5L8CVC-pU5CSbeYRY0@mail.gmail.com>
On 02/26/2011 06:44 PM, Prasad Joshi wrote:
> During device assignment the memory pre-fetchable flag was discarded
> as the IORESOURCE_PREFETCH was defined as 0x00001000 when instead it
> should have been 0x00002000. Following small patch fixes the problem,
> please apply.
>
Applied, thanks. Note this patch was somehow corrupted with 0xa0
characters instead of good old spaces. Please check your mail config.
> Signed-off-by: Prasad Joshi<prasadjoshi124@gmail.com>
> ---
> diff --git a/hw/device-assignment.c b/hw/device-assignment.c
> index e5205cf..2cfa155 100644
> --- a/hw/device-assignment.c
> +++ b/hw/device-assignment.c
> @@ -47,7 +47,7 @@
> #define IORESOURCE_MEM 0x00000200
> #define IORESOURCE_IRQ 0x00000400
> #define IORESOURCE_DMA 0x00000800
> -#define IORESOURCE_PREFETCH 0x00001000 /* No side effects */
> +#define IORESOURCE_PREFETCH 0x00002000 /* No side effects */
>
> /* #define DEVICE_ASSIGNMENT_DEBUG 1 */
> --
The last line from the diff was missing as well.
--
error compiling committee.c: too many arguments to function
prev parent reply other threads:[~2011-02-27 12:31 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <AANLkTinnFLueBvZ5FDiUZrMYuoh7LJN0ikjQrZ-yYnem@mail.gmail.com>
2011-02-26 16:44 ` [RESEND] [PATCH 1/1] qemu-kvm (device-assignment): detecting the pre-fectchable memory region Prasad Joshi
2011-02-27 12:31 ` Avi Kivity [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D6A4425.6000509@redhat.com \
--to=avi@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=prasadjoshi124@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox