From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [RESEND] [PATCH 1/1] qemu-kvm (device-assignment): detecting the pre-fectchable memory region. Date: Sun, 27 Feb 2011 14:31:33 +0200 Message-ID: <4D6A4425.6000509@redhat.com> References: Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org To: Prasad Joshi Return-path: Received: from mx1.redhat.com ([209.132.183.28]:6665 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750976Ab1B0Mbh (ORCPT ); Sun, 27 Feb 2011 07:31:37 -0500 In-Reply-To: Sender: kvm-owner@vger.kernel.org List-ID: On 02/26/2011 06:44 PM, Prasad Joshi wrote: > During device assignment the memory pre-fetchable flag was discarded > as the IORESOURCE_PREFETCH was defined as 0x00001000 when instead it > should have been 0x00002000. Following small patch fixes the problem, > please apply. > Applied, thanks. Note this patch was somehow corrupted with 0xa0 characters instead of good old spaces. Please check your mail config. > Signed-off-by: Prasad Joshi > --- > diff --git a/hw/device-assignment.c b/hw/device-assignment.c > index e5205cf..2cfa155 100644 > --- a/hw/device-assignment.c > +++ b/hw/device-assignment.c > @@ -47,7 +47,7 @@ > #define IORESOURCE_MEM 0x00000200 > #define IORESOURCE_IRQ 0x00000400 > #define IORESOURCE_DMA 0x00000800 > -#define IORESOURCE_PREFETCH 0x00001000 /* No side effects */ > +#define IORESOURCE_PREFETCH 0x00002000 /* No side effects */ > > /* #define DEVICE_ASSIGNMENT_DEBUG 1 */ > -- The last line from the diff was missing as well. -- error compiling committee.c: too many arguments to function