From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH 1/3] kvm-unit-tests: add x86 port io accessors Date: Sun, 27 Feb 2011 14:44:13 +0200 Message-ID: <4D6A471D.9050802@redhat.com> References: <1298584085-13129-1-git-send-email-aliguori@us.ibm.com> <1298584085-13129-2-git-send-email-aliguori@us.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org, qemu-devel@nongnu.org To: Anthony Liguori Return-path: Received: from mx1.redhat.com ([209.132.183.28]:41269 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751551Ab1B0MoZ (ORCPT ); Sun, 27 Feb 2011 07:44:25 -0500 In-Reply-To: <1298584085-13129-2-git-send-email-aliguori@us.ibm.com> Sender: kvm-owner@vger.kernel.org List-ID: On 02/24/2011 11:48 PM, Anthony Liguori wrote: > Signed-off-by: Anthony Liguori > > diff --git a/lib/x86/io.h b/lib/x86/io.h > new file mode 100644 > index 0000000..bd6341c > --- /dev/null > +++ b/lib/x86/io.h > @@ -0,0 +1,40 @@ > +#ifndef IO_H > +#define IO_H > + > +static inline unsigned char inb(unsigned short port) > +{ > + unsigned char value; > + asm volatile("inb %w1, %0" : "=a" (value) : "Nd" (port)); > + return value; > +} Are those %[wb] really needed? gcc should do the right thing based on the argument type. Might as well put all of that into processor.h. -- error compiling committee.c: too many arguments to function