From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH 1/2] KVM: VMX: write new TR selector value into vmcs immediately if it changes during vm86 mode. Date: Sun, 27 Feb 2011 17:38:32 +0200 Message-ID: <4D6A6FF8.7040907@redhat.com> References: <1298282879-23075-1-git-send-email-gleb@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: mtosatti@redhat.com, kvm@vger.kernel.org To: Gleb Natapov Return-path: Received: from mx1.redhat.com ([209.132.183.28]:24052 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752259Ab1B0Pif (ORCPT ); Sun, 27 Feb 2011 10:38:35 -0500 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p1RFcZwd022935 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Sun, 27 Feb 2011 10:38:35 -0500 In-Reply-To: <1298282879-23075-1-git-send-email-gleb@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On 02/21/2011 12:07 PM, Gleb Natapov wrote: > When vm86 is active TR descriptor is updated with vm86 task values, > but selector is left intact. vmx_set_segment() makes sure that if TR > register is written into while vm86 is active the new values are saved > for use after vm86 is deactivated, but since selector is not updated on > vm86 activation/deactivation new value is lost. Fix this by writing new > selector into vmcs immediately. Applied, thanks. -- error compiling committee.c: too many arguments to function