[PATCH] qemu-kvm: Mark VCPU state dirty on creation

[PATCH] qemu-kvm: Mark VCPU state dirty on creation

[Jan Kiszka]

This avoids that early cpu_synchronize_state calls try to retrieve an
uninitialized state from the kernel, which even causes a deadlock.

Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
---

Corresponding upstream patch will come with next uq/master series.

 qemu-kvm.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/qemu-kvm.c b/qemu-kvm.c
index 15e552a..106f148 100644
--- a/qemu-kvm.c
+++ b/qemu-kvm.c
@@ -259,6 +259,7 @@ static void kvm_create_vcpu(CPUState *env, int id)
 
     env->kvm_fd = r;
     env->kvm_state = kvm_state;
+    env->kvm_vcpu_dirty = 1;
 
     mmap_size = kvm_ioctl(kvm_state, KVM_GET_VCPU_MMAP_SIZE, 0);
     if (mmap_size < 0) {
-- 
1.7.1

Re: [PATCH] qemu-kvm: Mark VCPU state dirty on creation

[Avi Kivity]

On 02/21/2011 01:28 PM, Jan Kiszka wrote:
> This avoids that early cpu_synchronize_state calls try to retrieve an
> uninitialized state from the kernel,

Thanks, applied.

> which even causes a deadlock.
>

How?

-- 
error compiling committee.c: too many arguments to function

Re: [PATCH] qemu-kvm: Mark VCPU state dirty on creation

[Jan Kiszka]

On 2011-02-28 10:20, Avi Kivity wrote:
> On 02/21/2011 01:28 PM, Jan Kiszka wrote:
>> This avoids that early cpu_synchronize_state calls try to retrieve an
>> uninitialized state from the kernel,
> 
> Thanks, applied.
> 
>> which even causes a deadlock.
>>
> 
> How?

Early hw_error. It collects the CPU states, also during initial device
setup, ie. before the VCPUs have been started.

Jan

-- 
Siemens AG, Corporate Technology, CT T DE IT 1
Corporate Competence Center Embedded Linux