From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH] expose kvmclock upper msr set. Date: Mon, 28 Feb 2011 15:30:31 +0200 Message-ID: <4D6BA377.8070305@redhat.com> References: <1298483054-1665-1-git-send-email-glommer@redhat.com> <4D6A409E.9010107@redhat.com> <1298899495.15736.321.camel@mothafucka.localdomain> <4D6BA35E.6060504@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org To: Glauber Costa Return-path: In-Reply-To: <4D6BA35E.6060504@redhat.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: kvm.vger.kernel.org On 02/28/2011 03:30 PM, Avi Kivity wrote: > On 02/28/2011 03:24 PM, Glauber Costa wrote: >> On Sun, 2011-02-27 at 14:16 +0200, Avi Kivity wrote: >> > On 02/23/2011 07:44 PM, Glauber Costa wrote: >> > > We've been supporting kvmclock MSRs in the 0x4b564d00-0x4b564dff >> range >> > > for a while now, but we're not exposing it yet, meaning nobody >> is using it. >> > > This simple patch takes care of that. >> > >> > We're exposing them via KVM_GET_SUPPORTED_CPUID, leaf >> KVM_CPUID_FEATURES. >> > >> Our userspace does not really use it, and rely on the capability list. >> Historically, we've been relying on the capabilities mechanism to >> indicate what exists and what does not. > > Yes. I believe this bit marked the change point. > > Anyway, it's exposed, and it's a lot better for userspace to make use > of KVM_GET_SUPPORTED_CPUID since it will work on more kernels. > btw, it should work with -cpu host as well, no? -- error compiling committee.c: too many arguments to function