From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH v2 13/24] kvm: Set up signal mask also for !CONFIG_IOTHREAD Date: Mon, 28 Feb 2011 18:54:21 +0200 Message-ID: <4D6BD33D.8050405@redhat.com> References: <688de146287dc589a2e0fcce4cdec85d4f2c1127.1296594961.git.jan.kiszka@web.de> <4D6BC55B.9030805@redhat.com> <4D6BCA6A.9060507@siemens.com> <4D6BD144.5050406@redhat.com> <4D6BD220.6010606@siemens.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Marcelo Tosatti , "kvm@vger.kernel.org" , "qemu-devel@nongnu.org" To: Jan Kiszka Return-path: Received: from mx1.redhat.com ([209.132.183.28]:46532 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754264Ab1B1Qy2 (ORCPT ); Mon, 28 Feb 2011 11:54:28 -0500 In-Reply-To: <4D6BD220.6010606@siemens.com> Sender: kvm-owner@vger.kernel.org List-ID: On 02/28/2011 06:49 PM, Jan Kiszka wrote: > > > > That's what I tried, and it didn't work?! Maybe I forgot to compile or > > something. > > Well, it maybe failed to build as qemu_kvm_init_cpu_signals became > unused and the compiler should have bailed out? Probably it's better to > disable it directly in the function. > That's what I did, with #ifdefs, but brokenly (#ifndef). -- error compiling committee.c: too many arguments to function