From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH v2 13/24] kvm: Set up signal mask also for !CONFIG_IOTHREAD Date: Tue, 01 Mar 2011 11:03:47 +0200 Message-ID: <4D6CB673.4070702@redhat.com> References: <688de146287dc589a2e0fcce4cdec85d4f2c1127.1296594961.git.jan.kiszka@web.de> <4D6BC55B.9030805@redhat.com> <4D6BCA6A.9060507@siemens.com> <4D6BD144.5050406@redhat.com> <4D6BD220.6010606@siemens.com> <4D6BD33D.8050405@redhat.com> <4D6CB0DD.5030505@redhat.com> <4D6CB51E.2090006@siemens.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Marcelo Tosatti , "kvm@vger.kernel.org" , "qemu-devel@nongnu.org" To: Jan Kiszka Return-path: Received: from mx1.redhat.com ([209.132.183.28]:6742 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752588Ab1CAJD4 (ORCPT ); Tue, 1 Mar 2011 04:03:56 -0500 In-Reply-To: <4D6CB51E.2090006@siemens.com> Sender: kvm-owner@vger.kernel.org List-ID: On 03/01/2011 10:58 AM, Jan Kiszka wrote: > On 2011-03-01 09:39, Avi Kivity wrote: > > On 02/28/2011 06:54 PM, Avi Kivity wrote: > >> On 02/28/2011 06:49 PM, Jan Kiszka wrote: > >>>> > >>>> That's what I tried, and it didn't work?! Maybe I forgot to > >>> compile or > >>>> something. > >>> > >>> Well, it maybe failed to build as qemu_kvm_init_cpu_signals became > >>> unused and the compiler should have bailed out? Probably it's better to > >>> disable it directly in the function. > >>> > >> > >> That's what I did, with #ifdefs, but brokenly (#ifndef). > >> > >> > > > > Well it fails even with the correct #ifdef. Maybe some later patch adds > > to the breakage. > > But when ifdef'ed out, this patch should be a nop for qemu-kvm. Indeed > strange. Well, there are two functions in cpus.c named qemu_kvm_init_cpu_signals() (an intriguing coincidence). I #ifdefed the wrong one. With the right #ifdef it works correctly. > > > > This is really strange - the same test (migrate.tcp) works for Fedora > > and Windows XP x86. Installation and setup of Windows XP x64 work > > fine. It is only migration.tcp (when using netcat to connect to the > > guest) that fails. > > > > Guess this has to be classically debugged. :-/ Let me know if I can help > (though not today). Still has to be debugged, but at least the tree is alive now. -- error compiling committee.c: too many arguments to function