From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH] kvm: improve comment on rcu use in irqfd_deassign Date: Sun, 06 Mar 2011 14:36:19 +0200 Message-ID: <4D737FC3.9090801@redhat.com> References: <20110306110326.GA23818@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Marcelo Tosatti , kvm@vger.kernel.org, linux-kernel@vger.kernel.org To: "Michael S. Tsirkin" Return-path: In-Reply-To: <20110306110326.GA23818@redhat.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: kvm.vger.kernel.org On 03/06/2011 01:03 PM, Michael S. Tsirkin wrote: > The RCU use in kvm_irqfd_deassign is tricky: we have rcu_assign_pointer > but no synchronize_rcu: synchronize_rcu is done by kvm_irq_routing_update > which we share a spinlock with. > > Fix up a comment in an attempt to make this clearer. Applied, thanks. -- error compiling committee.c: too many arguments to function