From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: 2.6.38-rc6: general protection error inside KVM 64 bits guest Date: Sun, 06 Mar 2011 17:02:02 +0200 Message-ID: <4D73A1EA.1060702@redhat.com> References: <20110306124238.GC25565@redhat.com> <4D738435.1030906@redhat.com> <20110306143503.GD25565@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Francis Moreau , kvm@vger.kernel.org To: Gleb Natapov Return-path: Received: from mx1.redhat.com ([209.132.183.28]:2571 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751053Ab1CFPCJ (ORCPT ); Sun, 6 Mar 2011 10:02:09 -0500 In-Reply-To: <20110306143503.GD25565@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On 03/06/2011 04:35 PM, Gleb Natapov wrote: > > >+ r = ops->read_std(base + 102,&io_bitmap_ptr, 2, ctxt->vcpu, NULL); > > > if (r != X86EMUL_CONTINUE) > > > return false; > > > > Note: if we get a fault here, we ought to propagate it. Only > > happens if there's a race, since the cpu checks for these > > exceptions. > > > Do you mean we need to propagate fault that read_std() returns and not > always inject GP like we do now? Yes, it could be a #PF (or #TS or #NPF). (for #TS we need additional logic... will this arch never end?) -- error compiling committee.c: too many arguments to function