From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jan Kiszka <jan.kiszka@siemens.com>
Subject: Re: [PATCH] KVM: unbreak userspace that does not sets tss address
Date: Mon, 07 Mar 2011 16:49:28 +0100
Message-ID: <4D74FE88.9060708@siemens.com>
References: <20110307151936.GA10151@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Cc: kvm@vger.kernel.org, avi@redhat.com, mtosatti@redhat.com
To: Gleb Natapov <gleb@redhat.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from goliath.siemens.de ([192.35.17.28]:16083 "EHLO
	goliath.siemens.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1753494Ab1CGPtq (ORCPT <rfc822;kvm@vger.kernel.org>);
	Mon, 7 Mar 2011 10:49:46 -0500
In-Reply-To: <20110307151936.GA10151@redhat.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On 2011-03-07 16:19, Gleb Natapov wrote:
> Commit 6440e5967bc broke old userspaces that do not set tss address
> before entering vcpu. Unbreak it by setting tss address to a safe
> value on the first vcpu entry. New userspaces should set tss address,
> so print warning in case it doesn't.

Wouldn't allow runtime warnings but wouldn't it be cleaner otherwise to
start vcpus with a default tss address like that, ie. add the logic to
vmx_create_vcpu?

Jan

-- 
Siemens AG, Corporate Technology, CT T DE IT 1
Corporate Competence Center Embedded Linux