From mboxrd@z Thu Jan  1 00:00:00 1970
From: Anthony Liguori <aliguori@us.ibm.com>
Subject: Re: [PATCH 2/2] vnc: don't mess up with iohandlers in the vnc thread
Date: Thu, 10 Mar 2011 07:45:39 -0600
Message-ID: <4D78D603.5060000@us.ibm.com>
References: <4D7767C0.6060609@siemens.com> <1299761979-15197-2-git-send-email-corentin.chary@gmail.com> <4D78CCDF.6090906@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Cc: Corentin Chary <corentin.chary@gmail.com>,
	Jan Kiszka <jan.kiszka@siemens.com>, Peter Lieven <pl@dlh.net>,
	qemu-devel <qemu-devel@nongnu.org>, kvm@vger.kernel.org,
	Anthony Liguori <aliguori@linux.vnet.ibm.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from e9.ny.us.ibm.com ([32.97.182.139]:60196 "EHLO e9.ny.us.ibm.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1752683Ab1CJNpz (ORCPT <rfc822;kvm@vger.kernel.org>);
	Thu, 10 Mar 2011 08:45:55 -0500
Received: from d01dlp01.pok.ibm.com (d01dlp01.pok.ibm.com [9.56.224.56])
	by e9.ny.us.ibm.com (8.14.4/8.13.1) with ESMTP id p2ADJJ0Z014512
	for <kvm@vger.kernel.org>; Thu, 10 Mar 2011 08:19:19 -0500
Received: from d01relay07.pok.ibm.com (d01relay07.pok.ibm.com [9.56.227.147])
	by d01dlp01.pok.ibm.com (Postfix) with ESMTP id 1135A38C8038
	for <kvm@vger.kernel.org>; Thu, 10 Mar 2011 08:45:42 -0500 (EST)
Received: from d01av03.pok.ibm.com (d01av03.pok.ibm.com [9.56.224.217])
	by d01relay07.pok.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id p2ADjg4K2015236
	for <kvm@vger.kernel.org>; Thu, 10 Mar 2011 08:45:42 -0500
Received: from d01av03.pok.ibm.com (loopback [127.0.0.1])
	by d01av03.pok.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id p2ADjeLa017884
	for <kvm@vger.kernel.org>; Thu, 10 Mar 2011 10:45:42 -0300
In-Reply-To: <4D78CCDF.6090906@redhat.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On 03/10/2011 07:06 AM, Paolo Bonzini wrote:
> On 03/10/2011 01:59 PM, Corentin Chary wrote:
>> Instead, we now store the data in a temporary buffer, and use a socket
>> pair to notify the main thread that new data is available.
>
> You can use a bottom half for this instead of a special socket. 
> Signaling a bottom half is async-signal- and thread-safe.

Bottom halves are thread safe?

I don't think so.

They probably should be but they aren't today.

Regards,

Anthony Liguori

>
> Paolo