From mboxrd@z Thu Jan  1 00:00:00 1970
From: Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [PATCH 2/2] vnc: don't mess up with iohandlers in the vnc thread
Date: Thu, 10 Mar 2011 14:58:21 +0100
Message-ID: <4D78D8FD.9070006@redhat.com>
References: <4D7767C0.6060609@siemens.com>	<1299761979-15197-2-git-send-email-corentin.chary@gmail.com>	<4D78CCDF.6090906@redhat.com>	<4D78D603.5060000@us.ibm.com> <AANLkTi=WOPJ3eLAbTgYvStfbspahMzT3jUbroH2P2fUd@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Cc: Anthony Liguori <aliguori@us.ibm.com>,
	Jan Kiszka <jan.kiszka@siemens.com>, Peter Lieven <pl@dlh.net>,
	qemu-devel <qemu-devel@nongnu.org>, kvm@vger.kernel.org,
	Anthony Liguori <aliguori@linux.vnet.ibm.com>
To: Corentin Chary <corentin.chary@gmail.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx1.redhat.com ([209.132.183.28]:6161 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1751421Ab1CJN6c (ORCPT <rfc822;kvm@vger.kernel.org>);
	Thu, 10 Mar 2011 08:58:32 -0500
In-Reply-To: <AANLkTi=WOPJ3eLAbTgYvStfbspahMzT3jUbroH2P2fUd@mail.gmail.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On 03/10/2011 02:54 PM, Corentin Chary wrote:
> > >  You can use a bottom half for this instead of a special socket. Signaling
> > >  a bottom half is async-signal- and thread-safe.
> >
> >  Bottom halves are thread safe?
> >
> >  I don't think so.
>
> The bottom halves API is not thread safe, but calling
> qemu_bh_schedule_idle()

Not _idle please.

> in another thread *seems* to be safe (here, it
> would be protected from qemu_bh_delete() by vnc_lock_output()).

If it weren't protected against qemu_bh_delete, you would have already 
the same race between writing to the socket and closing it in another 
thread.

Paolo