From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jan Kiszka Subject: Re: [PATCH 12/15] kvm: Align kvm_arch_handle_exit to kvm_cpu_exec changes Date: Fri, 11 Mar 2011 08:33:47 +0100 Message-ID: <4D79D05B.3010402@web.de> References: <42c13eb02928b113fd6f4b5c013648d266e1ff4c.1299233998.git.jan.kiszka@siemens.com> <4D79CBAE.1040508@web.de> <933C3091-C7B5-4848-B302-5754C9DF212F@suse.de> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enig97607F2EF087099884950229" Cc: Avi Kivity , Marcelo Tosatti , kvm@vger.kernel.org, qemu-devel@nongnu.org To: Alexander Graf Return-path: Received: from fmmailgate01.web.de ([217.72.192.221]:51456 "EHLO fmmailgate01.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751333Ab1CKHdt (ORCPT ); Fri, 11 Mar 2011 02:33:49 -0500 In-Reply-To: <933C3091-C7B5-4848-B302-5754C9DF212F@suse.de> Sender: kvm-owner@vger.kernel.org List-ID: This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig97607F2EF087099884950229 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable On 2011-03-11 08:26, Alexander Graf wrote: >=20 > On 11.03.2011, at 08:13, Jan Kiszka wrote: >=20 >> On 2011-03-11 07:50, Alexander Graf wrote: >>> >>> On 04.03.2011, at 11:20, Jan Kiszka wrote: >>> >>>> Make the return code of kvm_arch_handle_exit directly usable for >>>> kvm_cpu_exec. This is straightforward for x86 and ppc, just s390 >>>> would require more work. Avoid this for now by pushing the return co= de >>>> translation logic into s390's kvm_arch_handle_exit. >>>> >>>> Signed-off-by: Jan Kiszka >>>> CC: Alexander Graf >>> >>> Looks good, haven't tested it though. Do you have a git tree for all = this? >>> >> >> See >> >> git://git.kiszka.org/qemu-kvm.git queues/kvm-upstream >=20 > With the following patch s390x-softmmu compiles and runs the bootloader= code just fine, breaks in early Linux boot code though. I haven't quite = figured out why yet. >=20 >=20 > diff --git a/Makefile.target b/Makefile.target > index 220589e..21106c6 100644 > --- a/Makefile.target > +++ b/Makefile.target > @@ -209,7 +209,7 @@ QEMU_CFLAGS +=3D $(VNC_PNG_CFLAGS) > obj-$(CONFIG_XEN) +=3D xen_machine_pv.o xen_domainbuild.o > =20 > # Inter-VM PCI shared memory > -obj-$(CONFIG_KVM) +=3D ivshmem.o > +obj-i386-$(CONFIG_KVM) +=3D ivshmem.o Looks like s390 hasn't been built for a while - or what makes this workaround necessary? > =20 > # Hardware support > obj-i386-y +=3D vga.o > diff --git a/exec.c b/exec.c > index 0b7a7b2..10e6528 100644 > --- a/exec.c > +++ b/exec.c > @@ -2963,7 +2963,7 @@ void qemu_ram_remap(ram_addr_t addr, ram_addr_t l= ength) > RAMBlock *block; > ram_addr_t offset; > int flags; > - void *area, *vaddr; > + void *area =3D NULL, *vaddr; > =20 > QLIST_FOREACH(block, &ram_list.blocks, next) { > offset =3D addr - block->offset; >=20 >=20 Yeah, we should abort() on mem_path !=3D 0 for unsupported targets. Jan --------------enig97607F2EF087099884950229 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.15 (GNU/Linux) Comment: Using GnuPG with SUSE - http://enigmail.mozdev.org/ iEYEARECAAYFAk150FsACgkQitSsb3rl5xTMMQCgx3dvhDHE7mRnwkPIOX3pe2Yd GR8An08DxwRHEThXJwZzc68hl8HdDjAZ =Tsom -----END PGP SIGNATURE----- --------------enig97607F2EF087099884950229--