Re: USB EHCI patch for 0.14.0?

[David Ahern <daahern@cisco.com>]

On 03/11/11 09:17, Markus Armbruster wrote:
> David Ahern <daahern@cisco.com> writes:
> 
>> On 03/11/11 08:39, Markus Armbruster wrote:
>>> erik.rull@rdsoftware.de writes:
>>>
>>>> Hi David,
>>>>
>>>> I did a second iteration and it looked way better, maybe my first attempts
>>>> were somehow buggy.
>>>>
>>>> First - please review your DPRINTF in the usb-ehci.c, there is a variable
>>>> "dev" undefined in line 504/505 when enabling the debugging defines at the
>>>> top of the file, the compiler complains there.
>>>>
>>>> I tested again with your hints, here my results:
>>>>
>>>> - using -device usb-host causes windows not to boot completely, using
>>>> -usbdevice host:auto:*.* is fine!
>>>>
>>>> - using -usbdevice tablet is better than using -device usb-tablet
>>>
>>> Better inhowfar?
>>
>> As I recall the USB code is the ignored step-child in qemu; it was never
>> properly/fully integrated into the qdev stuff. The paths appear to
>> differ in how usb devices are handled. I for one have always stuck with
>> the -usbdevice route.
> 
> Please report any deficiencies so we can fix this.

Erik reported a few above.

David

> 
> -usbdevice is around for backward compatibility only.  There are already
> cases where -device provides you more control than -usbdevice.  This
> feature gap will only grow.