From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH] kvm: fix crash on irqfd deassign Date: Tue, 22 Mar 2011 14:37:27 +0200 Message-ID: <4D889807.6000307@redhat.com> References: <20110317085333.GA7336@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Marcelo Tosatti , kvm@vger.kernel.org, linux-kernel@vger.kernel.org, jean-philippe.menil@univ-nantes.fr, stable@kernel.org, Jason Wang To: "Michael S. Tsirkin" Return-path: In-Reply-To: <20110317085333.GA7336@redhat.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: kvm.vger.kernel.org On 03/17/2011 10:53 AM, Michael S. Tsirkin wrote: > irqfd in kvm used flush_work incorrectly: > it assumed that work scheduled previously can't run > after flush_work, but since kvm uses a non-reentrant > workqueue (by means of schedule_work) > we need flush_work_sync to get that guarantee. > > Signed-off-by: Michael S. Tsirkin > Reported-by: Jean-Philippe Menil > Tested-by: Jean-Philippe Menil > --- > > Note: this is needed for kernel 2.6.39 and earlier. > What about kvm.git master? -- error compiling committee.c: too many arguments to function