From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH 1/5] KVM: x86 emulator: Use single stage decoding for Group 1 instructions Date: Tue, 22 Mar 2011 14:55:57 +0200 Message-ID: <4D889C5D.2000008@redhat.com> References: <20110314001524.f35e8a3f.takuya.yoshikawa@gmail.com> <20110314001727.89e302d7.takuya.yoshikawa@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: mtosatti@redhat.com, kvm@vger.kernel.org, yoshikawa.takuya@oss.ntt.co.jp, gleb@redhat.com To: Takuya Yoshikawa Return-path: Received: from mx1.redhat.com ([209.132.183.28]:56224 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755944Ab1CVM4D (ORCPT ); Tue, 22 Mar 2011 08:56:03 -0400 In-Reply-To: <20110314001727.89e302d7.takuya.yoshikawa@gmail.com> Sender: kvm-owner@vger.kernel.org List-ID: On 03/13/2011 05:17 PM, Takuya Yoshikawa wrote: > From: Takuya Yoshikawa > > ADD, OR, ADC, SBB, AND, SUB, XOR, CMP are converted using a new macro > I6ALU(_f, _e). > > CMPS, SCAS will be converted later. > @@ -2337,10 +2401,20 @@ static int em_mov(struct x86_emulate_ctxt *ctxt) > #define D6ALU(_f) D2bv((_f) | DstMem | SrcReg | ModRM), \ > D2bv(((_f) | DstReg | SrcMem | ModRM)& ~Lock), \ > D2bv(((_f)& ~Lock) | DstAcc | SrcImm) > +#define I6ALU(_f, _e) I2bv((_f) | DstMem | SrcReg | ModRM, _e), \ > + I2bv(((_f) | DstReg | SrcMem | ModRM)& ~Lock, _e), \ > + I2bv(((_f)& ~Lock) | DstAcc | SrcImm, _e) > I think you can remove D6ALU, no? -- error compiling committee.c: too many arguments to function