From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH 4/5] KVM: x86 emulator: Use single stage decoding for PUSHA and POPA instructions Date: Tue, 22 Mar 2011 15:07:20 +0200 Message-ID: <4D889F08.4070901@redhat.com> References: <20110314001524.f35e8a3f.takuya.yoshikawa@gmail.com> <20110314002152.fc032e5d.takuya.yoshikawa@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: mtosatti@redhat.com, kvm@vger.kernel.org, yoshikawa.takuya@oss.ntt.co.jp, gleb@redhat.com To: Takuya Yoshikawa Return-path: Received: from mx1.redhat.com ([209.132.183.28]:7549 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753763Ab1CVNH0 (ORCPT ); Tue, 22 Mar 2011 09:07:26 -0400 In-Reply-To: <20110314002152.fc032e5d.takuya.yoshikawa@gmail.com> Sender: kvm-owner@vger.kernel.org List-ID: On 03/13/2011 05:21 PM, Takuya Yoshikawa wrote: > From: Takuya Yoshikawa > > PUSHA and POPA are converted. > > Signed-off-by: Takuya Yoshikawa > --- > arch/x86/kvm/emulate.c | 19 ++++++++++++------- > 1 files changed, 12 insertions(+), 7 deletions(-) > > diff --git a/arch/x86/kvm/emulate.c b/arch/x86/kvm/emulate.c > index 8295c50..4e16a55 100644 > --- a/arch/x86/kvm/emulate.c > +++ b/arch/x86/kvm/emulate.c > @@ -2224,6 +2224,11 @@ static int em_push_gs(struct x86_emulate_ctxt *ctxt) > return X86EMUL_CONTINUE; > } > > +static int em_pusha(struct x86_emulate_ctxt *ctxt) > +{ > + return emulate_pusha(ctxt, ctxt->ops); > +} > + You can simply rename/update emulate_pusha/emulate_popa, since they have no other callers. -- error compiling committee.c: too many arguments to function