From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH 2/2] kvm/x86: remove unneeded substitute search for missing CPUID entries Date: Wed, 30 Mar 2011 15:33:29 +0200 Message-ID: <4D933129.3050509@redhat.com> References: <1301490106-20626-1-git-send-email-andre.przywara@amd.com> <1301490106-20626-2-git-send-email-andre.przywara@amd.com> <4D932F69.8070205@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org, stable@kernel.org To: Andre Przywara Return-path: Received: from mx1.redhat.com ([209.132.183.28]:22953 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754738Ab1C3Ndf (ORCPT ); Wed, 30 Mar 2011 09:33:35 -0400 In-Reply-To: <4D932F69.8070205@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On 03/30/2011 03:26 PM, Avi Kivity wrote: > > This behaviour is mandated by the spec (looking at the Intel one), > though it is implemented incorrectly - should always return largest > basic leaf, and ignore the kvm leaves. > > I think the correct behaviour is: > > if (e->function < 10000 && (!best || e->function > best->function)) > best = e; > Oh, and it should honor ecx.. what a great interface. -- error compiling committee.c: too many arguments to function