From: "Justin P. Mattock" <justinmattock@gmail.com>
To: Avi Kivity <avi@redhat.com>
Cc: trivial@kernel.org, kvm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH]arch:x86:kvm:i8254.h Fix typo in kvm_pit
Date: Wed, 30 Mar 2011 09:30:59 -0700 [thread overview]
Message-ID: <4D935AC3.2030509@gmail.com> (raw)
In-Reply-To: <4D9359CC.6050508@redhat.com>
On 03/30/2011 09:26 AM, Avi Kivity wrote:
> On 03/30/2011 06:19 PM, Justin P. Mattock wrote:
>> The below patch changes base_addresss to base_address.
>> Note: I have grepped for base_addresss and nothing shows up,
>> grepping for base_address gets me lots of output, telling me that
>> this is a typo, but could be wrong.
>>
>> Signed-off-by: Justin P. Mattock<justinmattock@gmail.com>
>>
>> ---
>> arch/x86/kvm/i8254.h | 2 +-
>> 1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/arch/x86/kvm/i8254.h b/arch/x86/kvm/i8254.h
>> index 46d08ca..c2fa48b 100644
>> --- a/arch/x86/kvm/i8254.h
>> +++ b/arch/x86/kvm/i8254.h
>> @@ -33,7 +33,7 @@ struct kvm_kpit_state {
>> };
>>
>> struct kvm_pit {
>> - unsigned long base_addresss;
>> + unsigned long base_address;
>> struct kvm_io_device dev;
>> struct kvm_io_device speaker_dev;
>> struct kvm *kvm;
>
> Why not remove the variable completely?
>
didnt even think to completely remove the variable(figured it was used
somewhere).I will look at that and resend with removal of the variable
for you..
Justin P. Mattock
next prev parent reply other threads:[~2011-03-30 16:30 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-30 16:19 [PATCH]arch:x86:kvm:i8254.h Fix typo in kvm_pit Justin P. Mattock
2011-03-30 16:26 ` Avi Kivity
2011-03-30 16:30 ` Justin P. Mattock [this message]
2011-03-30 17:17 ` Avi Kivity
2011-03-30 17:42 ` Justin P. Mattock
2011-03-31 9:20 ` Avi Kivity
2011-03-31 15:50 ` Justin P. Mattock
2011-03-30 22:21 ` Jiri Kosina
2011-03-30 23:52 ` Justin P. Mattock
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D935AC3.2030509@gmail.com \
--to=justinmattock@gmail.com \
--cc=avi@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=trivial@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox