From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH 0/15] KVM: Make the instruction emulator aware of Nested Virtualization v4 Date: Sun, 03 Apr 2011 15:42:14 +0300 Message-ID: <4D986B26.9000208@redhat.com> References: <1301667024-29420-1-git-send-email-joerg.roedel@amd.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Marcelo Tosatti , kvm@vger.kernel.org To: Joerg Roedel Return-path: Received: from mx1.redhat.com ([209.132.183.28]:1787 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752293Ab1DCMmV (ORCPT ); Sun, 3 Apr 2011 08:42:21 -0400 In-Reply-To: <1301667024-29420-1-git-send-email-joerg.roedel@amd.com> Sender: kvm-owner@vger.kernel.org List-ID: On 04/01/2011 05:10 PM, Joerg Roedel wrote: > Hi, > > this is version 4 of this patch-set. The main change to the previous > version is that now the intruction permission checks for interceptable > instructions are seperated to make the checks before the actual > intercept condition is checked. > For this I added the check_perm call-back to the opcode structure and > populated it where necessary. > One check was put into a new flag: 'Prot'. This is used for all > instructions that are only recognized in protected mode. > As usual, any feedback is appreciated. Other than the cosmetic comment on 4/15, looks good. -- error compiling committee.c: too many arguments to function