From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [RFC PATCH 2/2] KVM: x86 emulator: Cleanup emulate_push() writebacks Date: Sun, 03 Apr 2011 19:11:11 +0300 Message-ID: <4D989C1F.6070703@redhat.com> References: <20110329013229.20e6168f.takuya.yoshikawa@gmail.com> <20110329013407.c7bcadcc.takuya.yoshikawa@gmail.com> <4D988927.4020003@redhat.com> <20110404005907.0edba901.takuya.yoshikawa@gmail.com> <4D989A7F.8000700@redhat.com> <20110404010910.c4d417ff.takuya.yoshikawa@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: mtosatti@redhat.com, kvm@vger.kernel.org, yoshikawa.takuya@oss.ntt.co.jp, gleb@redhat.com To: Takuya Yoshikawa Return-path: Received: from mx1.redhat.com ([209.132.183.28]:44114 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751321Ab1DCQLV (ORCPT ); Sun, 3 Apr 2011 12:11:21 -0400 In-Reply-To: <20110404010910.c4d417ff.takuya.yoshikawa@gmail.com> Sender: kvm-owner@vger.kernel.org List-ID: On 04/03/2011 07:09 PM, Takuya Yoshikawa wrote: > > > IMHO, we are using dst operand for too many things. > > > > > > In the case of CMP, I first tried to use src2 to clearly follow the > > > SDM's "second source operand" terminology. But it seemed not worth > > > it now. > > > > > > > Ah, CMP is encoded as dst/src, so it's best to just disable writeback > > there. We could have a bit in the decode tables to auto-disable > > writeback, but not sure it is worth it. > > One more question: > > Why some functions in this file are defined using > "static inline" not just "static" ? > > I should keep these "inline" ? > Just 'static' is enough, the compiler can usually make the best decision wrt. inline. -- error compiling committee.c: too many arguments to function