From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH] KVM: SVM: Fix fault-rip on vmsave/vmload emulation Date: Wed, 06 Apr 2011 14:28:24 +0300 Message-ID: <4D9C4E58.7020002@redhat.com> References: <1302085803-25399-1-git-send-email-joerg.roedel@amd.com> <4D9C4C9C.6060401@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Marcelo Tosatti , kvm@vger.kernel.org, stable@kernel.org To: Joerg Roedel Return-path: Received: from mx1.redhat.com ([209.132.183.28]:20492 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754224Ab1DFL2b (ORCPT ); Wed, 6 Apr 2011 07:28:31 -0400 In-Reply-To: <4D9C4C9C.6060401@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On 04/06/2011 02:21 PM, Avi Kivity wrote: > On 04/06/2011 01:30 PM, Joerg Roedel wrote: >> When the emulation of vmload or vmsave fails because the >> guest passed an unsupported physical address it gets an #GP >> with rip pointing to the instruction after vmsave/vmload. >> This is a bug and fixed by this patch. >> > > Applied, thanks. > btw, I think the actual address check is incorrect, need to check MAXPHYADDR and not hardcoded 0xffff000000000000. -- error compiling committee.c: too many arguments to function