From mboxrd@z Thu Jan 1 00:00:00 1970 From: Anthony Liguori Subject: Re: [Qemu-devel] [PATCH 2/2 V7] qemu,qmp: add inject-nmi qmp command Date: Wed, 06 Apr 2011 13:03:37 -0500 Message-ID: <4D9CAAF9.7000509@codemonkey.ws> References: <4D74A8C9.2020408@cn.fujitsu.com> <4D74A974.6090509@cn.fujitsu.com> <20110404105949.GA30324@redhat.com> <4D99BF99.1040305@redhat.com> <4D99C22C.4070401@codemonkey.ws> <20110406144723.45333682@doriath> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Lai Jiangshan , Jiangshan , kvm@vger.kernel.org, Markus Armbruster , qemu-devel@nongnu.org, Avi Kivity To: Luiz Capitulino Return-path: Received: from mail-gy0-f174.google.com ([209.85.160.174]:37208 "EHLO mail-gy0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754812Ab1DFSDq (ORCPT ); Wed, 6 Apr 2011 14:03:46 -0400 Received: by gyd10 with SMTP id 10so672373gyd.19 for ; Wed, 06 Apr 2011 11:03:46 -0700 (PDT) In-Reply-To: <20110406144723.45333682@doriath> Sender: kvm-owner@vger.kernel.org List-ID: On 04/06/2011 12:47 PM, Luiz Capitulino wrote: > On Mon, 04 Apr 2011 08:05:48 -0500 > Anthony Liguori wrote: > >> On 04/04/2011 07:54 AM, Avi Kivity wrote: >>> On 04/04/2011 01:59 PM, Daniel P. Berrange wrote: >>>> Interesting that with HMP you need to specify a single CPU index, but >>>> with QMP it is injecting to all CPUs at once. Is there any compelling >>>> reason why we'd ever need the ability to only inject to a single CPU >>>> from an app developer POV ? >>> When a PC has an NMI button, it is (I presume) connected to all CPUs' >>> LINT1 pin, which is often configured as an NMI input. So the all-cpu >>> variant corresponds to real hardware, while the single-cpu variant >>> doesn't. >>> >>> wrt the app developer POV, the only use I'm aware of is that you can >>> configure Windows to dump core when the NMI button is pressed and thus >>> debug driver problems. It's likely more reliable when sent to all cpus. >> It either needs to be removed from HMP or added to QMP. HMP shouldn't >> have more features than QMP (even if those features are non-sensible). > Is anyone against changing HMP behavior to send it to all CPUs? Makes sense to me. Regards, Anthony Liguori