From: Pekka Enberg <penberg@cs.helsinki.fi>
To: Asias He <asias.hejun@gmail.com>
Cc: Cyrill Gorcunov <gorcunov@gmail.com>, Ingo Molnar <mingo@elte.hu>,
Prasad Joshi <prasadjoshi124@gmail.com>,
kvm@vger.kernel.org
Subject: Re: [PATCH 3/3] kvm tools: add virtio console support v2
Date: Thu, 07 Apr 2011 08:50:21 +0300 [thread overview]
Message-ID: <4D9D509D.3010903@cs.helsinki.fi> (raw)
In-Reply-To: <1302228309-6583-3-git-send-email-asias.hejun@gmail.com>
Hi Asias,
On 4/8/11 5:05 AM, Asias He wrote:
> - Consolidate all console related code to term.c
> - Use timer based approach instead of thread to deal with user input
> - Introduce --enable-virtio-console option, this option disables
> serial console output
>
> NOTE:
> Please add something like this:
> T2:23:respawn:/sbin/getty -L hvc0 9600 vt100
> to your /etc/inittab file to get a virtio console login.
>
> Signed-off-by: Asias He<asias.hejun@gmail.com>
> ---
> tools/kvm/8250-serial.c | 40 +-----
> tools/kvm/Makefile | 2 +
> tools/kvm/console-virtio.c | 218 ++++++++++++++++++++++++++++++++
> tools/kvm/include/kvm/8250-serial.h | 2 +-
> tools/kvm/include/kvm/console-virtio.h | 9 ++
> tools/kvm/include/kvm/term.h | 17 +++
> tools/kvm/main.c | 48 ++-----
> tools/kvm/term.c | 89 +++++++++++++
Is it too much trouble to ask you to split this patch into two: (1) the
term.c refactoring and (2) virtio console implementation? That would
make the series much easier to review.
Pekka
next prev parent reply other threads:[~2011-04-07 5:50 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-08 2:05 [PATCH 1/3] kvm tools: define marcros for virtio device io space size and pci device number Asias He
2011-04-07 3:56 ` David Ahern
2011-04-07 4:40 ` Pekka Enberg
2011-04-07 7:38 ` Avi Kivity
2011-04-08 2:05 ` [PATCH 2/3] kvm tools: add some helper functions for virt_queue Asias He
2011-04-08 2:05 ` [PATCH 3/3] kvm tools: add virtio console support v2 Asias He
2011-04-07 5:50 ` Pekka Enberg [this message]
2011-04-08 14:18 ` Asias He
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D9D509D.3010903@cs.helsinki.fi \
--to=penberg@cs.helsinki.fi \
--cc=asias.hejun@gmail.com \
--cc=gorcunov@gmail.com \
--cc=kvm@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=prasadjoshi124@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox