From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pekka Enberg Subject: Re: [PATCH 3/3] kvm tools: add virtio console support v2 Date: Thu, 07 Apr 2011 08:50:21 +0300 Message-ID: <4D9D509D.3010903@cs.helsinki.fi> References: <1302228309-6583-1-git-send-email-asias.hejun@gmail.com> <1302228309-6583-3-git-send-email-asias.hejun@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Cyrill Gorcunov , Ingo Molnar , Prasad Joshi , kvm@vger.kernel.org To: Asias He Return-path: Received: from courier.cs.helsinki.fi ([128.214.9.1]:35552 "EHLO mail.cs.helsinki.fi" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752003Ab1DGFuY (ORCPT ); Thu, 7 Apr 2011 01:50:24 -0400 In-Reply-To: <1302228309-6583-3-git-send-email-asias.hejun@gmail.com> Sender: kvm-owner@vger.kernel.org List-ID: Hi Asias, On 4/8/11 5:05 AM, Asias He wrote: > - Consolidate all console related code to term.c > - Use timer based approach instead of thread to deal with user input > - Introduce --enable-virtio-console option, this option disables > serial console output > > NOTE: > Please add something like this: > T2:23:respawn:/sbin/getty -L hvc0 9600 vt100 > to your /etc/inittab file to get a virtio console login. > > Signed-off-by: Asias He > --- > tools/kvm/8250-serial.c | 40 +----- > tools/kvm/Makefile | 2 + > tools/kvm/console-virtio.c | 218 ++++++++++++++++++++++++++++++++ > tools/kvm/include/kvm/8250-serial.h | 2 +- > tools/kvm/include/kvm/console-virtio.h | 9 ++ > tools/kvm/include/kvm/term.h | 17 +++ > tools/kvm/main.c | 48 ++----- > tools/kvm/term.c | 89 +++++++++++++ Is it too much trouble to ask you to split this patch into two: (1) the term.c refactoring and (2) virtio console implementation? That would make the series much easier to review. Pekka