From mboxrd@z Thu Jan 1 00:00:00 1970 From: Anthony Liguori Subject: Re: [Qemu-devel] [PATCH 2/2 V7] qemu,qmp: add inject-nmi qmp command Date: Thu, 07 Apr 2011 16:41:03 -0500 Message-ID: <4D9E2F6F.3040008@codemonkey.ws> References: <4D9CAAF9.7000509@codemonkey.ws> <20110406150818.56707b9b@doriath> <4D9CAE4B.7080305@siemens.com> <20110406160020.373cb5a2@doriath> <4D9CC044.2000705@codemonkey.ws> <4D9E0352.2050204@codemonkey.ws> <20110407185108.GE7100@redhat.com> <20110407191759.GG7100@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=KOI8-R; format=flowed Content-Transfer-Encoding: 7bit Cc: Blue Swirl , Peter Maydell , Lai Jiangshan , Jiangshan , kvm@vger.kernel.org, Jan Kiszka , qemu-devel@nongnu.org, Markus Armbruster , Avi Kivity , Luiz Capitulino To: Gleb Natapov Return-path: Received: from mail-gx0-f174.google.com ([209.85.161.174]:38534 "EHLO mail-gx0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752813Ab1DGVlF (ORCPT ); Thu, 7 Apr 2011 17:41:05 -0400 Received: by gxk21 with SMTP id 21so1205825gxk.19 for ; Thu, 07 Apr 2011 14:41:05 -0700 (PDT) In-Reply-To: <20110407191759.GG7100@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On 04/07/2011 02:17 PM, Gleb Natapov wrote: > On Thu, Apr 07, 2011 at 10:04:00PM +0300, Blue Swirl wrote: >> On Thu, Apr 7, 2011 at 9:51 PM, Gleb Natapov wrote: >> >> I'd prefer something more generic like these: >> raise /apic@fee00000:l1int >> lower /i44FX-pcihost/e1000@03.0/pinD >> >> The clumsier syntax shouldn't be a problem, since this would be a >> system developer tool. >> >> Some kind of IRQ registration would be needed for this to work without >> lots of changes. > True. The ability to trigger any interrupt line is very useful for > debugging. I often re-implement it during debug. And it's a good thing to have, but exposing this as the only API to do something as simple as generating a guest crash dump is not the friendliest thing in the world to do to users. Regards, Anthony Liguori > -- > Gleb. >